Attention is currently required from: arehbein, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34224 ) Change subject: stream tests: Eliminate timestamps from output ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: First of all, I think we can agree that not knowing the cause for these timestamps is unsatisfactory. I tried to reproduce the issue, but after fixing issues with the leak sanitizer I wasn't able to see wrong timestamps. You can see my commits in daniel/stream_tests_lsan Secondly, in https://gerrit.osmocom.org/c/libosmo-netif/+/33198/16#message-034bf24dc42f2… Pau seems to be in favor of disabling timestamps in tests in general. I think this is a good idea - especially with the io_uring backend which certainly causes different amount of mainloop invocations than poll. Another solution would be to avoid calling osmo_gettimeofday_override_add() inside the osmo_select_main() loop, but only when e.g. a read/write callback is called. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34224 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7faed932927d4f6e328a28c7f30a647a7272e89c Gerrit-Change-Number: 34224 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Sep 2023 15:25:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment