Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33094 ) Change subject: libosmogsm: Add support for TUAK authentication algorithm ...................................................................... Patch Set 4: (219 comments) File src/gsm/tuak/KeccakP-1600-3gpp.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4fbf1d96_b62a03e9 PS4, Line 22: EXPORTIT void Keccak_f_8 (uint8_t s[200]); space prohibited between function name and open parenthesis '(' File src/gsm/tuak/KeccakP-1600-3gpp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9c93cacd_da59664f PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e92c5a95_23ba3ed7 PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0eb06fb5_ce1b8ea4 PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1ebf4965_f2a97d90 PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/59feda5a_f2bebe82 PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6edc6cb4_88834268 PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/360f3d1c_8811dfb1 PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c75afcf2_33721964 PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/80acb102_1423f47e PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6a54a941_71318bf4 PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/faf46d46_c764395a PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2310f1b3_fe72fa18 PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ae525fdb_6912d30c PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/eefdafd8_3fb51bac PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d052d502_2e1cf68f PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fb480078_2cae54d2 PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3528f135_b13bdd83 PS4, Line 13: 15,21,8,18,2,61,56,14}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/38e65da5_c79916f3 PS4, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7ef454d4_eae872d3 PS4, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4e723fce_0ef659a3 PS4, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a1e61a67_a12b0a63 PS4, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/13483ef5_1d326262 PS4, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fd562331_0e64f37d PS4, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fd4d20b5_147c808a PS4, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ac2086c9_d041ca22 PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/73875d79_aa0bdeb6 PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/747bb79b_638a4d37 PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/774585b7_1fb66bf5 PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/56a4af76_5ce37ed4 PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/10a120d1_42b720d3 PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/353471e4_5d2782d9 PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5072f818_054c9481 PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/52f671a5_b0f2adde PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6217f3a6_0bc0a137 PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/31f569f5_b4e15b5b PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a0af7d61_b215edbc PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ad28d304_e531551b PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4b5c0ce2_37f23a3e PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2b571429_974ee52c PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b09c1449_acc39b8a PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/701ea8e7_ef83d0c1 PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/78bf1a27_4277d7fb PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bcb85b98_715be946 PS4, Line 16: 23,2,8,14,15,21}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fb3126bf_6b7c81c9 PS4, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c695d6c8_58452231 PS4, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/892be86a_ecf401e1 PS4, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2bd64b65_8587c885 PS4, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/19fdf3d8_6a18f20f PS4, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/670c84fa_438f1406 PS4, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9788660e_1d7ee686 PS4, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9117a6f2_8af62d6f PS4, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7274dc4f_40434ec9 PS4, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/56c04f42_1df0c3ff PS4, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9a15a263_f4e09063 PS4, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0f20a11f_aa29cd69 PS4, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/78165ccb_2a6a3346 PS4, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9c50e8ae_204abcb4 PS4, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bf7adc45_b285825a PS4, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/36c35f38_c4fa8796 PS4, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1e66428c_d49d9352 PS4, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4afe3ccf_5d00ba2c PS4, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5d8a0249_af9b9472 PS4, Line 19: 217,83,82,192,26,106,241,208,33,120}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b60b49dd_2149c184 PS4, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4c883f6b_09cf8b2e PS4, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d7a27cf5_b0039b59 PS4, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f8e6c446_25356e3b PS4, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4e788906_d7d4b0b1 PS4, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c276b5c3_4eef6db2 PS4, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8768caff_c45c9438 PS4, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/351b8fe4_bdfa40b6 PS4, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2686a46d_ec4e1459 PS4, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7aef8b63_1a5485f1 PS4, Line 32: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6f4e34a2_9a281d80 PS4, Line 32: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/dd617fa5_138816c3 PS4, Line 32: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4e6ad8e1_2f7a45eb PS4, Line 32: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9e162a46_7d4c909c PS4, Line 34: for(i=0; i<5; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/13ab707e_82bd9479 PS4, Line 34: for(i=0; i<5; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b081404a_01439c08 PS4, Line 34: for(i=0; i<5; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5ef8117a_8dd809e3 PS4, Line 36: for(i=0; i<5; ++i, s+=5) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/19e20b68_ed6d5c65 PS4, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ced519d5_478d698e PS4, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d28faf12_2bef6675 PS4, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2f9bfd4d_7e84946b PS4, Line 36: for(i=0; i<5; ++i, s+=5) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5df69878_af3f30ea PS4, Line 46: for(i=1; i<25; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8ea136e3_24b01a83 PS4, Line 46: for(i=1; i<25; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/05b27ceb_675833bf PS4, Line 46: for(i=1; i<25; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/33152df2_3738123f PS4, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e3dd9e41_c3379211 PS4, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3cdf7d92_f705a47c PS4, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/479b0a8a_16a31dd6 PS4, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/031d18ac_aa908fa1 PS4, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a5f8227d_361d6c11 PS4, Line 54: for(i=0; i<5; ++i, s += 5) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bda56d09_6a4fb214 PS4, Line 54: for(i=0; i<5; ++i, s += 5) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b16c750d_311f9a70 PS4, Line 54: for(i=0; i<5; ++i, s += 5) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/36a254a6_8b238eae PS4, Line 54: for(i=0; i<5; ++i, s += 5) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9ad007b6_d6c13d4a PS4, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b92618bf_dd9bce5e PS4, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/94638253_24b2516e PS4, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9be91819_fbd72cbe PS4, Line 66: *s ^= (t[0] | (t[0]<<11) | (t[0]<<26) | (t[0]<<57)) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/78db0585_43ebbb24 PS4, Line 67: & 0x800000008000808BULL; /* set & mask bits 0,1,3,7,15,31,63 */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b86b9fc4_af699bf5 PS4, Line 67: & 0x800000008000808BULL; /* set & mask bits 0,1,3,7,15,31,63 */ please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8a2d0ba7_8c0b31f1 PS4, Line 79: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/606d60dd_d2210843 PS4, Line 79: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6e3b9468_e646e08a PS4, Line 79: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/27a3d8ee_298bfb34 PS4, Line 79: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1be7acb4_dd7eead0 PS4, Line 81: for(i=0; i<40; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f94fcf4e_06c1484d PS4, Line 81: for(i=0; i<40; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d3d3d0b7_22890c01 PS4, Line 81: for(i=0; i<40; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/27bf1067_34c36693 PS4, Line 82: t[i]=s[i]^s[40+i]^s[80+i]^s[120+i]^s[160+i]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a6a2fb37_79acce43 PS4, Line 83: for(i=0; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f06f3177_706d8270 PS4, Line 83: for(i=0; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5cff53fb_f1de6863 PS4, Line 83: for(i=0; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0c067394_0357a5c2 PS4, Line 83: for(i=0; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d4b519ee_8f54a5c7 PS4, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/98797555_d485b42e PS4, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e6fde1db_7a1a7241 PS4, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f669ca87_a902cbc5 PS4, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/89172641_284317e1 PS4, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e56dbe9a_ebc23628 PS4, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/596bb431_d8a88022 PS4, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e812cbba_d986eb03 PS4, Line 87: for(j = t[i+7]>>7, k=7; k; --k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/87500794_cdeaf5c9 PS4, Line 87: for(j = t[i+7]>>7, k=7; k; --k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6874c56a_3df5b5db PS4, Line 89: for(i=0; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b8e54204_b8f65508 PS4, Line 89: for(i=0; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9a320431_f1629c6d PS4, Line 89: for(i=0; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7b5dc9be_b5ab1b7f PS4, Line 89: for(i=0; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b0b47fbd_8c576497 PS4, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9789060f_25da5874 PS4, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b2109ab2_cd9fa939 PS4, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8394449e_b0bf2638 PS4, Line 94: for(i=8; i<200; i+=8) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/92d78018_c06f3596 PS4, Line 94: for(i=8; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e8ec74e7_be873f67 PS4, Line 94: for(i=8; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/24217db1_0d88f8d4 PS4, Line 94: for(i=8; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1c02f1aa_9dd7b819 PS4, Line 94: for(i=8; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9a4d52cb_590b9777 PS4, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5af14f8a_7e3b7155 PS4, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4a4a0c76_78c68edf PS4, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/07a71f60_ca5b87d5 PS4, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/60861582_47f5011b PS4, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c8a21ac7_b1b98614 PS4, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d08768fe_2e94fe58 PS4, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d258e704_5f7f5a04 PS4, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a09a3973_f1800b2f PS4, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/81198a1b_cc104c37 PS4, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/15e82e4b_3220a497 PS4, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/14efd6da_684d83cb PS4, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bde487c6_d7419d4f PS4, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2086f792_0e11365f PS4, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7f134cdd_1b0b8701 PS4, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a62b7b9c_6580d52a PS4, Line 104: for(i=1; (j=Pi[i])>1; i=j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/163bfce5_94e49c61 PS4, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/448201bc_7cc3dfd8 PS4, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8a53f8f6_0109094a PS4, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3fdc7ef5_cbe095e7 PS4, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/39735b48_cb672110 PS4, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5d8cf2da_17180cd5 PS4, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3e57d197_3a8f7e3c PS4, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/44a321fa_381b9923 PS4, Line 111: for(i=0; i<200; i+=40) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/33296e38_1df73684 PS4, Line 111: for(i=0; i<200; i+=40) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ca54e4f4_f289d1c5 PS4, Line 111: for(i=0; i<200; i+=40) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5b688ab6_a1c215ad PS4, Line 111: for(i=0; i<200; i+=40) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0c97155d_7139a5c7 PS4, Line 111: for(i=0; i<200; i+=40) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/647e3c60_bf6c702d PS4, Line 112: { for(j=0; j<40; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/40a5e849_fe1f94db PS4, Line 112: { for(j=0; j<40; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/57658d33_2ca5d419 PS4, Line 112: { for(j=0; j<40; ++j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6f53dc83_8b80e44c PS4, Line 113: t[j]=(~s[i+(j+8)%40]) & s[i+(j+16)%40]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5432aab5_07bf978e PS4, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c1bf5e2c_9b48d018 PS4, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5eacaa05_1ff971dc PS4, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '^=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a8147833_4ea6582a PS4, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3414e598_485010b8 PS4, Line 135: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5773fbd3_c6d63ebf PS4, Line 135: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8cb8de7c_917597d2 PS4, Line 135: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2a7693cc_b88a3cdd PS4, Line 135: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7119df79_47422e43 PS4, Line 137: for(i=0; i<10; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/877f74c6_2e2e2b35 PS4, Line 137: for(i=0; i<10; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0cb45ce5_61ae9008 PS4, Line 137: for(i=0; i<10; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d4ea9f7b_aa940e29 PS4, Line 139: for(i=0; i<5; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c02fb4a5_750b1aa6 PS4, Line 139: for(i=0; i<5; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8df439de_80d23aa6 PS4, Line 139: for(i=0; i<5; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/04b9b8e4_96495a8a PS4, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8d04e2c5_ffd27e09 PS4, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/09761575_60eefb31 PS4, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ac22a3a7_ea564b37 PS4, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '%=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/136b7573_44877d2f PS4, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c53286dc_35ef38f8 PS4, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b12fac06_c4f31ccc PS4, Line 143: if(j==8) break; spaces required around that '==' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/640c4005_f302dc63 PS4, Line 143: if(j==8) break; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b5166b8b_a774fc7e PS4, Line 148: for(i=2; i<50; i+=2) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/994b8834_3ab71388 PS4, Line 148: for(i=2; i<50; i+=2) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/14cd5e9d_c8ded4bb PS4, Line 148: for(i=2; i<50; i+=2) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a238912a_9bf55242 PS4, Line 148: for(i=2; i<50; i+=2) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/eaf99a0a_a246cd92 PS4, Line 148: for(i=2; i<50; i+=2) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cfda8403_bd2f5c39 PS4, Line 153: s[i] = t[1-k], s[i+1] = t[k]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e0619f3b_2918714e PS4, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/46bd8622_1e5a3bfb PS4, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5a456af3_9dea9b84 PS4, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e58a8208_96e6c2c8 PS4, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/97747be7_b4d520ed PS4, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4b153a55_e6f02657 PS4, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/01e094ff_4371b1d1 PS4, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/af9b0083_be90190b PS4, Line 158: s[i]=s[j], s[i+1]=s[j+1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e89b6e3c_80c227c8 PS4, Line 158: s[i]=s[j], s[i+1]=s[j+1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/76f3ca2a_5edd3f1f PS4, Line 158: s[i]=s[j], s[i+1]=s[j+1]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/949a8fbb_e5e9919d PS4, Line 159: s[i]=t[0], s[i+1]=t[1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a931366e_725514f6 PS4, Line 159: s[i]=t[0], s[i+1]=t[1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7ec53ea8_2487ece1 PS4, Line 159: s[i]=t[0], s[i+1]=t[1]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e69a0982_bafe9d1f PS4, Line 162: for(i=0; i<5; ++i, s+=10) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/26c6895c_48cb7d7c PS4, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/32a604a4_47bb4f84 PS4, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/20a85d75_095e168a PS4, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1d095736_28897f6e PS4, Line 162: for(i=0; i<5; ++i, s+=10) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/050d07a2_115fb844 PS4, Line 163: { for(j=0; j<10; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2b605832_da8eb09a PS4, Line 163: { for(j=0; j<10; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/edaceb5c_3070b779 PS4, Line 163: { for(j=0; j<10; ++j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f0289b63_438c24e8 PS4, Line 165: for(j=0; j<10; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/991ba12a_2f67e93d PS4, Line 165: for(j=0; j<10; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d87a6055_15840fb9 PS4, Line 165: for(j=0; j<10; ++j) space required before the open parenthesis '(' -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d Gerrit-Change-Number: 33094 Gerrit-PatchSet: 4 Gerrit-Owner: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Comment-Date: Tue, 30 May 2023 14:52:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment