Attention is currently required from: laforge, pespin.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/32931 )
Change subject: ASCI: Add IE transcoding according to 3GPP TS 48.008
......................................................................
Patch Set 4:
(2 comments)
File include/osmocom/gsm/gsm0808_utils.h:
https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/469078d6_a8668c0a
PS1, Line 33: #include <sys/socket.h>
After correcting my patches, this change is not
required anymore, so I removed it.
Done
File src/gsm/gsm0808_utils.c:
https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/756dcd13_a5f5e83f
PS1, Line 2517: *ci = osmo_load32le(elem);
Yes, this is LE. I added a comment line that states
it.
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/32931
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic1fc714bb04228a7f32e9925811e21c8efc610bd
Gerrit-Change-Number: 32931
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 24 May 2023 12:50:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment