Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30926 ) Change subject: upf/PFCP: do not imply f_inet_addr() ...................................................................... Patch Set 2: (3 comments) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30926/comment/ac6665f2_8ac9… PS2, Line 1318: var F_SEID up_f_seid := valueof(ts_PFCP_F_SEID_ipv4(f_inet_addr("127.0.0.1"), '1111111111111111'O)); yes i realized that recently, already changed the template. this caller didn't reflect that yet -- not related to this patch File library/PFCP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30926/comment/c4b9c67a_ef24… PS2, Line 327: template (value) Outer_Header_Creation ts_PFCP_Outer_Header_Creation_GTP_ipv4(OCT4 remote_teid, OCT4 remote_addr_v4) := { seems odd for a "native" type like OCT4? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30926/comment/83bfc739_54f0… PS2, Line 423: Create_PDR_list create_pdr, yes but separate patch -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30926 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib068831787f4256f70a2189a5f36ca1ea1f40c9e Gerrit-Change-Number: 30926 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Jan 2023 13:34:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment