Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29907 ) Change subject: fsm: add ignore_invalid_event_mask bit-mask ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: IMHO this causes even more difficulties to understand FSM code (both the FSM implementation and users of the FSM) by having to look at yet another place for flow of events. I think it's totally fine having to add the possible events on each state, it helps understanding what may be possible by readers who look at it. Logging incorrect events sent at a given point is also good, because it allows learning that some scenarios are also possible and need to be taken into account. So my opinion right now is that I see no need for this change. Other feel free to provide their own opinion on the topic. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29907 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id010ade76de83ccf428f2d18e9f85bcce1d1ea2c Gerrit-Change-Number: 29907 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 28 Oct 2022 10:32:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment