Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28783 )

Change subject: sdp_msg: add sdp_audio_codecs_cmp(), add compare flags ......................................................................

Patch Set 1:

(1 comment)

File src/libmsc/sdp_msg.c:

https://gerrit.osmocom.org/c/osmo-msc/+/28783/comment/812e2c62_ce7ce7e9 PS1, Line 38: int sdp_audio_codec_cmp(const struct sdp_audio_codec *a, const struct sdp_audio_codec *b,

This becomes quite difficult to gasp, and seems to be doing too many things. […]

see the commit log.

i have written this code a long time ago, and made it work in practice. i am not sure yet how fmtp should be handled properly, so i'd like to come back to this later. during the osmodevcall talk about these patches, i recall that you suggested to merge as-is first and fix this aspect later

these patches are in active use at a customer's site, for a long time, so they should be useful, if not perfect.

this API is limited to osmo-msc.git, not public API, it is easy to refactor this later without compat problems.