Attention is currently required from: neels.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-pfcp/+/31760 )
Change subject: libosmo-pfcp.pc: move libosmogsm to Requires
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
And indeed, the linker command while building
libosmo-pfcp seems to be: […]
So in libosmoi-pfcp/Makefile.am you are
* including LIBOSMOGSM_LIBS in AM_LDFLAGS (where it doesn't belong, but let's set
that aside for now)
* then overriding those flags by using libosmo_pfcp_la_LDFLAGS *without* including
LDFLAGS. So all other programs/libraries/targets (that don't have a
prog_name_LDFLAGS) will be linked against libosmocore, but not the library itself
As a result, you have a library that depens on other librarires, but which doesn't
express this dependency to the dynamic linker at runtime.
pkg-config can't fix that. pkg-config is just metadata for easy discovery of linker
flags / cflags, and it has to assume the libraries are correctly linked in the first
place.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-pfcp/+/31760
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I319173c1fab068dfe1361ae6cd02f729461d4cf8
Gerrit-Change-Number: 31760
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 14 Mar 2023 20:25:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment