laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37482?usp=email ) Change subject: pySim.transport: Fix proactive_handler from_dict() calls ...................................................................... pySim.transport: Fix proactive_handler from_dict() calls Change-Id: I2aa19ef6a19085d77c1b4f2d434a01ee241bd9a8 --- M pySim/transport/__init__.py 1 file changed, 15 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/transport/__init__.py b/pySim/transport/__init__.py index dd06af8..5ae9428 100644 --- a/pySim/transport/__init__.py +++ b/pySim/transport/__init__.py @@ -187,9 +187,11 @@ # they could be appended after the Result; if the first is a # Result, that cuold replace the one built here. self.proactive_handler.receive_fetch_raw(pcmd, parsed) - result.from_dict({'general_result': 'performed_successfully', 'additional_information': ''}) + result.from_dict({'result': {'general_result': 'performed_successfully', + 'additional_information': ''}}) else: - result.from_dict({'general_result': 'command_beyond_terminal_capability', 'additional_information': ''}) + result.from_dict({'result': {'general_result': 'command_beyond_terminal_capability', + 'additional_information': ''}}) # Send response immediately, thus also flushing out any further # proactive commands that the card already wants to send @@ -200,7 +202,8 @@ (command_details,) = [c for c in pcmd.decoded.children if isinstance(c, CommandDetails)] # The Device Identities are fixed. (TS 102 223 V4.0.0 Section 6.8.2) device_identities = DeviceIdentities() - device_identities.from_dict({'source_dev_id': 'terminal', 'dest_dev_id': 'uicc'}) + device_identities.from_dict({'device_identities': {'source_dev_id': 'terminal', 'dest_dev_id': + 'uicc'}}) # Testing hint: The value of tail does not influence the behavior # of an SJA2 that sent ans SMS, so this is implemented only -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37482?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2aa19ef6a19085d77c1b4f2d434a01ee241bd9a8 Gerrit-Change-Number: 37482 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged