Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/31967 )
Change subject: contrib: Add BER testing tool
......................................................................
Patch Set 2:
(27 comments)
File contrib/ber/rtp_ber.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/427d5fa7_30472afb
PS2, Line 97: static const char *amr_rate_by_ft[] = {
static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/86e7e3b1_e03af4d9
PS2, Line 237: for (i=0; i<8*payload_len; i++)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/4cef6491_add2e004
PS2, Line 237: for (i=0; i<8*payload_len; i++)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/bf1838e0_46510b07
PS2, Line 237: for (i=0; i<8*payload_len; i++)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/f1063f62_e8565ebb
PS2, Line 246: if (ones < 32) // This frames is probably us underrunning Tx,
don't use it
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/4d0bb175_2120f038
PS2, Line 258: if (as->state == RUNNING)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/6ca1abc9_8a7ac241
PS2, Line 361: else
else should follow close brace '}'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/e7474286_7b18f2e0
PS2, Line 399: if (as->state == WAIT_CONN)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/c6ebc284_e574ee4d
PS2, Line 420: if (rtp_seq_num_diff(seq_number, as->rx_last_seq) > 1) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/a57c2be6_5c64ce8c
PS2, Line 431: if (d > 1)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/2cff74b5_5c573e9b
PS2, Line 485: while (1) {
braces {} are not necessary for single statement blocks
File contrib/ber/rtp_gen_map.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/d56992f8_51a10fa0
PS2, Line 30: int i,j;
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/216852af_8d7d87f7
PS2, Line 34: for (i=0; i<260; i++)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/5936d239_1fd521ec
PS2, Line 34: for (i=0; i<260; i++)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/46319a01_0c36e038
PS2, Line 34: for (i=0; i<260; i++)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/8c3612b0_fe66755f
PS2, Line 55: for (i=0; i<260; i++)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/cc365cfa_236463da
PS2, Line 55: for (i=0; i<260; i++)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/21f43138_68856b00
PS2, Line 55: for (i=0; i<260; i++)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/ef1595b1_62cd281f
PS2, Line 96: for (i=0; i<16; i++)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/6bb7fe3b_ec3654e4
PS2, Line 96: for (i=0; i<16; i++)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/234eef65_3c294cd6
PS2, Line 99: for (i=0; i<244; i++)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/3a597644_9d175fa8
PS2, Line 99: for (i=0; i<244; i++)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/86cc6816_634184b2
PS2, Line 102: for (i=0; i<4; i++)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/29efa67b_49ff0b8a
PS2, Line 102: for (i=0; i<4; i++)
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/4651b98a_5aa8ecee
PS2, Line 116: for (i=0; i<len; i++)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/4802efab_dc455e66
PS2, Line 116: for (i=0; i<len; i++)
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5224):
https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/1d6d5ce0_95be08f1
PS2, Line 116: for (i=0; i<len; i++)
spaces required around that '<' (ctx:VxV)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/31967
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1cffa0ae959e29ec61775b13185fd1057ed7485a
Gerrit-Change-Number: 31967
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-CC: Jenkins Builder
Gerrit-CC: tnt <tnt(a)246tNt.com>
Gerrit-Comment-Date: Fri, 17 Mar 2023 17:50:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment