Attention is currently required from: laforge. jtavares has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/30138 ) Change subject: rspro_client: implement re-establish delay ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: Replying to use of const File src/rspro_client_fsm.c: https://gerrit.osmocom.org/c/osmo-remsim/+/30138/comment/cf082a84_6f94675e PS1, Line 227: const It might have only come about in C90 or C99-- I honestly don't know the history, but it has been there for a while. I admit that it is a pattern found more in C++ than C codebases, but I'm personally very much in favor of it as a good practice. Helps express the intent, and prevents accidental changes in a variety of situations. That said, ultimately this your project and so if you prefer it removed, just let me know and I can nuke it. I'll leave unless I hear otherwise. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30138 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I86cdc3ba37482e6577b429194d273a2399f32208 Gerrit-Change-Number: 30138 Gerrit-PatchSet: 2 Gerrit-Owner: jtavares <jtavares(a)kvh.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 14 Nov 2022 16:18:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment