Attention is currently required from: laforge. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/34427?usp=email ) Change subject: gsm_12_21.h: fix values for NM_IPAC_F_GPRS_CODING_MCS[1-9] ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: These flags are applied to a `uint32_t` value in **native** endianness for the host. nanoBTS and osmo-bts report a value in network byte order, which needs to be converted to host's byte order before doing any `u32 & NM_IPAC_F_` checks. * osmo-bsc: see `ipacc_parse_supp_flags()` for a usage example, * osmo-bts: grep for `NM_IPAC_F_CHANT_`. The problem this patch is solving is not about endianness, it's about wrong offset values assigned to MCS related `NM_IPAC_F_` constants. We should get this merged to fix parsing of the feature reports sent by nanoBTS. As a side effect, this will change the bit-vector sent by osmo-bts, but it's not critical because we never request GPRS related features from osmo-bts and so far only using this for informative purposes. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34427?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I85316af9b57e8113077305798cb2d82a24e48e00 Gerrit-Change-Number: 34427 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 19 Oct 2024 07:09:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>