dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37470?usp=email ) Change subject: IPAd_Tests: add missing verification of ESipa responses from IPAd ...................................................................... IPAd_Tests: add missing verification of ESipa responses from IPAd Some of the ESipa messages comming from the IPAd are not verified. Related: SYS#6563 Change-Id: I0150fe5c98d5a5db9f1931c72ef6e015f74055bd --- M ipad/IPAd_Tests.ttcn 1 file changed, 22 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/70/37470/1 diff --git a/ipad/IPAd_Tests.ttcn b/ipad/IPAd_Tests.ttcn index 1ede0b3..0cac37e 100644 --- a/ipad/IPAd_Tests.ttcn +++ b/ipad/IPAd_Tests.ttcn @@ -447,8 +447,11 @@ esipa_res := valueof(ts_getBoundProfilePackageResponseEsipa); esipa_req := f_esipa_transceive(esipa_res); + if (not match(esipa_req, tr_getBoundProfilePackageRequestEsipa)) { + setverdict(fail, "unexpected message from IPAd"); + } + boundProfilePackage := esipa_res.getBoundProfilePackageResponseEsipa.getBoundProfilePackageOkEsipa.boundProfilePackage; - /* TODO: match response (we do not have a template yet) */ /* initialiseSecureChannelRequest */ f_vpcd_transceive(''O); @@ -485,7 +488,9 @@ /* Receive ProfileInstallationResult from iPAD->eIM */ esipa_req := f_esipa_transceive_empty_response(); - /* TODO: match response (we do not have a template yet) */ + if (not match(esipa_req, tr_handleNotificationEsipa_prfleInstRslt)) { + setverdict(fail, "unexpected message from IPAd"); + } /* Receive RemoveNotificationFromList from iPAD->eUICC */ f_vpcd_transceive(enc_NotificationSentResponse(valueof(ts_notificationSentResponse))); @@ -658,6 +663,9 @@ /* IPAd will return the data to us */ esipa_res := valueof(ts_provideEimPackageResultResponse_eimAck(eimAcknowledgements := {1,2,3,4})); esipa_req := f_esipa_transceive(esipa_res); + if (not match(esipa_req, tr_provideEimPackageResult_euiccDataResp)) { + setverdict(fail, "unexpected message from IPAd"); + } /* Wait some time until the the last HTTP response is actually delivered */ f_sleep(2.0); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37470?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0150fe5c98d5a5db9f1931c72ef6e015f74055bd Gerrit-Change-Number: 37470 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange