Attention is currently required from: lynxis lazus.
Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email )
Change subject: Rework SGSN code to use new libvlr code ......................................................................
Patch Set 6:
(24 comments)
File src/sgsn/gprs_gmm.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/daf1629a_0c97d3e7?usp... : PS6, Line 1220: if (req.mi.type == GSM_MI_TYPE_IMSI) { braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/14e63a18_f5007796?usp... : PS6, Line 1290: if (!mmctx->attach_rau.rau_fsm || rc != 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/4db19c2b_b562aaf5?usp... : PS6, Line 1551: else { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/c6166ac4_639f7622?usp... : PS6, Line 1555: if (TLVP_PRESENT(&req.tlv, GSM48_IE_GMM_PTMSI_TYPE)) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/91fda4e7_f00d3999?usp... : PS6, Line 1673: if (!foreign_ra && that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/14896aeb_5552aaf0?usp... : PS6, Line 1759: if (!strlen(mmctx->imsi) && strlen(mmctx->vsub->imsi)) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/78f4295e_c001709f?usp... : PS6, Line 1787: if (mmctx) { braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/6b78ede5_501da541?usp... : PS6, Line 1817: if (!mmctx->attach_rau.rau_fsm || rc != 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/9297f0df_64449487?usp... : PS6, Line 1964: } else { else is not generally useful after a break or return
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/0f34db6b_7a21275b?usp... : PS6, Line 2321: if (!strlen(mmctx->imsi) && strlen(mmctx->vsub->imsi)) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/da8258bf_f56f855c?usp... : PS6, Line 2345: /* FIXME: when loosing the VLR subscriber, we should ensure the GMM is in IDLE (same for PMM) */ 'loosing' may be misspelled - perhaps 'losing'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/b6d1c058_0e98bd27?usp... : PS6, Line 2372: if (ctx->p_tmsi != send_tmsi && ctx->p_tmsi != GSM_RESERVED_TMSI && send_tmsi != GSM_RESERVED_TMSI) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/e5d51136_a8976f8b?usp... : PS6, Line 2387: if (ctx->attach_rau.rau_fsm) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/a655e1eb_1bcfa0c4?usp... : PS6, Line 2393: switch(ctx->ran_type) { space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/9d4ff373_76ac1739?usp... : PS6, Line 2431: if (ctx->iu.mm_state_fsm->state == ST_PMM_CONNECTED) { braces {} are not necessary for single statement blocks
File src/sgsn/gprs_rau_fsm.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/13e136e2_cd5b5e2c?usp... : PS6, Line 206: switch(mmctx->ran_type) { space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/e8ca730d_8e66b097?usp... : PS6, Line 231: switch(mmctx->ran_type) { space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/d3cf1fa1_da0674a3?usp... : PS6, Line 304: .in_event_mask = S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_VLR_RAU_ACCEPT) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/4f6de339_e5488365?usp... : PS6, Line 310: .in_event_mask = S(GMM_RAU_E_UE_RAU_COMPLETE) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_RAU_ACCEPT) | S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/fa284522_9eb93561?usp... : PS6, Line 339: static __attribute__((constructor)) void gmm_rau_fsm_init() Bad function definition - void gmm_rau_fsm_init() should probably be void gmm_rau_fsm_init(void)
File src/sgsn/mmctx.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/5f83ef30_acf92318?usp... : PS6, Line 619: if (!strlen(mm->imsi) && strlen(mm->vsub->imsi)) { braces {} are not necessary for single statement blocks
File src/sgsn/sgsn_libgtp.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/33ec51e9_b1cad3fb?usp... : PS6, Line 537: if (cause != GTPCAUSE_NON_EXIST) { braces {} are not necessary for single statement blocks
File src/sgsn/sgsn_main.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/398fe2fa_8ca38a34?usp... : PS6, Line 360: [DVLR] = { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/01002ba7_22591023?usp... : PS6, Line 364: }, please, no spaces at the start of a line
-
Jenkins Builder