Attention is currently required from: fixeria. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38054?usp=email ) Change subject: pySim.transport: Add support for generic stdout apdu tracer ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File pySim/transport/__init__.py: https://gerrit.osmocom.org/c/pysim/+/38054/comment/f41aa4de_25dddce0?usp=em… : PS1, Line 258: 'apdu_tracer' in kwargs we have two different apdu tracers: 1) the early stdout apdu tracer that can be enabled in the transport by this new --apdu-trace command line argument, for all of the programs using pySim.transport 2) the classic one that pySim-shell can enable at the command line with 'set apdu_trace true'. This will be in the kwargs here, and it will print using the cmd2 output functions. The latter was insufficient as it was too late for debugging APDUs generated by pySim startup (like we read ICCID, EID, detect AIDs, etc.). -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38054?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4bc3d2e023ba360f07f024d7b661a93322f87530 Gerrit-Change-Number: 38054 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Sep 2024 18:28:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>