[S] Change in pysim[master]: pySim-shell: add cardinfo command - gerrit-log

27 Mar 2023


      Attention is currently required from: laforge, fixeria.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/25805 )
Change subject: pySim-shell: add cardinfo command
......................................................................
Patch Set 5:
(2 comments)
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/25805/comment/7fd4b474_d04f8506 
PS2, Line 611: p
...
the transport code already works this way: the get_atr() method retrieves acached version of the atr […]
Thanks. I wasn't aware of this.
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/25805/comment/c4cc32df_44ada15f 
PS4, Line 743: print
...
Why not using `poutput()` here?
Done
-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/25805
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: If31ed17102dc0108e27a5eb0344aabaaf19b19f9
Gerrit-Change-Number: 25805
Gerrit-PatchSet: 5
Gerrit-Owner: dexter pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Mon, 27 Mar 2023 08:39:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge laforge@osmocom.org
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Comment-In-Reply-To: dexter pmaier@sysmocom.de
Gerrit-MessageType: comment