Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31967 ) Change subject: contrib: Add BER testing tool ...................................................................... Patch Set 1: (27 comments) File contrib/ber/rtp_ber.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/ef8f3388_919d98a3 PS1, Line 97: static const char *amr_rate_by_ft[] = { static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/e9d84e03_18182f30 PS1, Line 237: for (i=0; i<8*payload_len; i++) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/c9a30369_8eaa9998 PS1, Line 237: for (i=0; i<8*payload_len; i++) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/0adeacd7_9cbd315a PS1, Line 237: for (i=0; i<8*payload_len; i++) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/b9e6e8f9_4aa1dbef PS1, Line 246: if (ones < 32) // This frames is probably us underrunning Tx, don't use it that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/414c7fb6_09f58d46 PS1, Line 258: if (as->state == RUNNING) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/e5a95e52_bd028ee7 PS1, Line 361: else else should follow close brace '}' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/711e1aca_070adcf0 PS1, Line 399: if (as->state == WAIT_CONN) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/4cdae59c_6e01deab PS1, Line 420: if (rtp_seq_num_diff(seq_number, as->rx_last_seq) > 1) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/df5fb29c_977e3a50 PS1, Line 431: if (d > 1) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/f760bdfe_5ff19c5a PS1, Line 485: while (1) { braces {} are not necessary for single statement blocks File contrib/ber/rtp_gen_map.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/3bb403a3_f414e2d4 PS1, Line 30: int i,j; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/0097fc13_ecfa3061 PS1, Line 34: for (i=0; i<260; i++) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/5c2ed603_7bebd829 PS1, Line 34: for (i=0; i<260; i++) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/618720d9_4f06d026 PS1, Line 34: for (i=0; i<260; i++) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/648f470c_07a8f471 PS1, Line 55: for (i=0; i<260; i++) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/27d15f81_aa0e5c31 PS1, Line 55: for (i=0; i<260; i++) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/9299913e_02ede7b6 PS1, Line 55: for (i=0; i<260; i++) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/dde8cd40_6a687e22 PS1, Line 96: for (i=0; i<16; i++) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/ed2346d9_8d4ffd55 PS1, Line 96: for (i=0; i<16; i++) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/6c2b3101_f9c1e98c PS1, Line 99: for (i=0; i<244; i++) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/f15301d5_8a6d75fb PS1, Line 99: for (i=0; i<244; i++) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/dd16db4b_ce4d7946 PS1, Line 102: for (i=0; i<4; i++) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/3d8c40e3_b7994932 PS1, Line 102: for (i=0; i<4; i++) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/3d2e446a_858b5d21 PS1, Line 116: for (i=0; i<len; i++) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/0f76ab5e_9b7d8095 PS1, Line 116: for (i=0; i<len; i++) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5223): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/8efd8c38_b74135b5 PS1, Line 116: for (i=0; i<len; i++) spaces required around that '<' (ctx:VxV) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31967 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1cffa0ae959e29ec61775b13185fd1057ed7485a Gerrit-Change-Number: 31967 Gerrit-PatchSet: 1 Gerrit-Owner: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-CC: Jenkins Builder Gerrit-CC: tnt &lt;tnt(a)246tNt.com&gt; Gerrit-Comment-Date: Fri, 17 Mar 2023 17:45:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment