Attention is currently required from: fixeria.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-pfcp/+/30502 )
Change subject: gtlv: decoding error: log size limited hexdump of IE
......................................................................
Patch Set 4:
(1 comment)
File src/libosmo-gtlv/gtlv_dec_enc.c:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/30502/comment/677d6f05_300be5fd
PS4, Line 224: osmo_hexdump
We may want to have a special version of
osmo_hexdump_max() in libosmocore.
would fit well, but i think this here is simple
enough that we don't need to extend the API.
(btw i'm using the "legacy" version returning a static buffer because
libosmo-gtlv must not make assumptions on allocation handling = cannot use OTC_SELECT)
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-pfcp/+/30502
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Ie814a117db3dfea32cf3f01cf124a2e472cb869f
Gerrit-Change-Number: 30502
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 11 Dec 2022 23:00:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment