Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30993 ) Change subject: layer23: Introduce netdev.{c,h} ...................................................................... Patch Set 3: (42 comments) File src/host/layer23/include/osmocom/bb/common/netdev.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/b920e976_003bf638 PS3, Line 33: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/22e85fc4_539d92d8 PS3, Line 33: { open brace '{' following struct go on the same line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/b247faac_f05da831 PS3, Line 35: unsigned int ihl:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/df3c7c2a_d6d60ade PS3, Line 36: unsigned int version:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/5242029b_12cc14db PS3, Line 38: unsigned int version:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/cf94586f_9729539c PS3, Line 39: unsigned int ihl:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/f62d2dd2_407e214c PS3, Line 43: u_int8_t tos; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/1fb37d0b_dd638fbb PS3, Line 44: u_int16_t tot_len; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/14b32e7d_8a99d43e PS3, Line 45: u_int16_t id; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/a0ce83e6_ddce111f PS3, Line 46: u_int16_t frag_off; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/ea667dd2_780a859e PS3, Line 47: u_int8_t ttl; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/c062de8a_aa98aac9 PS3, Line 48: u_int8_t protocol; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/c35a03fb_0475a91a PS3, Line 49: u_int16_t check; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/c9b26aa0_027c61e9 PS3, Line 50: u_int32_t saddr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/84ad15a6_45133cc8 PS3, Line 51: u_int32_t daddr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/ae8cfaba_ec18280a PS3, Line 53: }; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/993e069b_b4c8a08d PS3, Line 57: struct osmo_sockaddr addr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/c49b416e_516fcce8 PS3, Line 58: uint8_t prefixlen; please, no spaces at the start of a line File src/host/layer23/src/common/netdev.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/3d287169_882a87f4 PS3, Line 45: #elif defined (__FreeBSD__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/a6957d0a_4f6bc195 PS3, Line 49: #elif defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/558860be_b323b9e4 PS3, Line 61: #define SYS_ERR(sub, pri, en, fmt, args...) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/764e50ca_df382f07 PS3, Line 97: strncpy(ifr.ifr_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/5d645794_1a63cf4d PS3, Line 125: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/a6a75aa0_83775314 PS3, Line 132: strncpy(ifr.ifr_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/31f7af22_3e5a560e PS3, Line 160: if (ioctl(fd, SIOCSIFDSTADDR, (caddr_t) & ifr) < 0) { space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/5f570ccf_4bfb6e7e PS3, Line 172: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/bfd69be4_b30bc55a PS3, Line 191: #if defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/53c0e6f2_0ab09a14 PS3, Line 213: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/64135cfc_76405da1 PS3, Line 214: strncpy(ifr.ifr_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/94f8fad2_8e3956c0 PS3, Line 249: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/28876227_8c3cfe09 PS3, Line 381: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/af73546c_54df38de PS3, Line 381: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/791f3469_d7b5c299 PS3, Line 387: strncpy(areq.ifra_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/91a6da68_1bc571c4 PS3, Line 530: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/d1492f0a_6ff3f03d PS3, Line 530: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/6840fa56_b642dee1 PS3, Line 536: strncpy(areq.ifra_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/aa1540a5_0ccbb4a4 PS3, Line 608: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/46344686_ab9b6d82 PS3, Line 677: strncpy(ifr.ifr_name, gw_iface, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/9a2b9663_08e1cff7 PS3, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/fc61ff76_263344ff PS3, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/0e05f914_ae53f040 PS3, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2796): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/efca8180_b7640b05 PS3, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I6085dc6861687bd4e9c32e86221c0375ad95ba22 Gerrit-Change-Number: 30993 Gerrit-PatchSet: 3 Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Comment-Date: Tue, 17 Jan 2023 12:39:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment