tnt has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39153?usp=email )
Change subject: voicebus: Don't check BAR0 is an IO resource ......................................................................
voicebus: Don't check BAR0 is an IO resource
BAR0 isn't actually _used_ by anything, all commnication goes through BAR1 which is MMIO.
So that check just prevents it to work on devices that don't support IO transactions at all (like RPi5) but for no good reason.
Change-Id: I3c6fe1664e8dc3f158c64d16640b912fa5a4d12e Signed-off-by: Sylvain Munaut tnt@246tNt.com --- M drivers/dahdi/voicebus/voicebus.c 1 file changed, 0 insertions(+), 5 deletions(-)
Approvals: laforge: Looks good to me, but someone else must approve tnt: Looks good to me, approved; Verified pespin: Looks good to me, but someone else must approve
diff --git a/drivers/dahdi/voicebus/voicebus.c b/drivers/dahdi/voicebus/voicebus.c index 8a1f7a6..eb110ea 100644 --- a/drivers/dahdi/voicebus/voicebus.c +++ b/drivers/dahdi/voicebus/voicebus.c @@ -1794,11 +1794,6 @@ goto cleanup; }
- if (0 == (pci_resource_flags(vb->pdev, 0)&IORESOURCE_IO)) { - dev_err(&vb->pdev->dev, "BAR0 is not IO Memory.\n"); - retval = -EIO; - goto cleanup; - } vb->iobase = pci_iomap(vb->pdev, 1, 0); if (request_mem_region(pci_resource_start(vb->pdev, 1), pci_resource_len(vb->pdev, 1),
-
tnt