Attention is currently required from: jolly, pespin, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32694 ) Change subject: gprs_rlcmac: also use direct TLLI PCUIF for paging MAC blocks ...................................................................... Patch Set 2: (4 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/0debb836_982fe0c5 PS1, Line 7: gprs_rlcmac: also use direct TLLI PCUIF for paging macblocks I just mean a MAC block with a paging message inside. We generate those with write_paging_request() and send them to osmo-bts as a whole. Osmo-bts then does not interpret them any further it just sends them. https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/284a0019_88ae299f PS1, Line 28: OS##5927 Done File src/gprs_rlcmac.c: https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/6f6be98f_5405e950 PS1, Line 20: #include <osmocom/core/bitvec.h> I had problems getting the bitvec type recognized but in the end it was just a missing struct in the function signature. I forgot to remove this one again. https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/27912027_fe7a93ae PS1, Line 49: mi->tmsi gprs_rlcmac_paging_request() is called from gprs_bssgp_pcu.c:gprs_bssgp_pcu_rx_paging_ps(), which calls get_paging_ps_mi() to generate the mi. And this mi is always of type GSM_MI_TYPE_TMSI. So at least in that regard we should be fine. (we might consider to add an OSMO_ASSERT) As far as I am aware use the same the same identifier in TLLI and TMSI even though both could be different. However, after all, we do not do anything different than we did before since the MAC block we generate is also based on the same value. When the confirmation comes back, everything seems to end up in bts.cpp:tlli_from_imm_ass(), where we either use the direct TLLI value or extract the value from the MAC block. Whet confuses me though is that tlli_from_imm_ass() is apparently not able to handle paging_request macblocks even though osmo-bts sends confirmations for those. This is really confusing. Do you have an idea? I am a bit lost here. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I99cfe373fa157cfb32b74c113ad9935347653a71 Gerrit-Change-Number: 32694 Gerrit-PatchSet: 2 Gerrit-Owner: dexter &lt;pmaier(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: jolly &lt;andreas(a)eversberg.eu&gt; Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: jolly &lt;andreas(a)eversberg.eu&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Comment-Date: Mon, 15 May 2023 12:45:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt; Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-MessageType: comment