Attention is currently required from: pespin, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32758 ) Change subject: osmo_io: Improve handling of segmentation_cb ...................................................................... Patch Set 3: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/32758/comment/672ec2f1_eb5f3948 PS3, Line 9: int in File include/osmocom/core/osmo_io.h: https://gerrit.osmocom.org/c/libosmocore/+/32758/comment/95c9980d_082c90b2 PS3, Line 46: * Needs to return the size of the next segment. If it returns pespin: The point of osmo_io is to be a one-stop shop for all users of the kind of telecom protocols that we see - irrespective of whether they're on SEQPACKET bearers like SCTP or on the cumbersome "preserve message boundaries over TCP stream" approahc that IPA does. This significantly unifies code that has to deal with both variants, such as e.g. a BSC speaking BSSAP over either M3UA/SCTP or over IPA. The user should be concerned with sending or receiving protocol-level messages, and not be botered with TCP stream segmentation. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6a0eebb8d4490f09a3cc6eb97d4ff47b4a8fd377 Gerrit-Change-Number: 32758 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 May 2023 10:13:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment