Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28846 ) Change subject: Make esme struct shared ...................................................................... Patch Set 7: (6 comments) File src/libmsc/smpp_smsc.c: https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/84078fec_c7fe2773 PS7, Line 163: struct esme *esme = acl->esme->esme; Not sure what doyouwin with this change here. In fact, it looks more confusing. https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/f40092de_aad2f148 PS7, Line 242: osmo_wqueue_clear(&esme->esme->wqueue); Sound like you want to move this block to some API to free the "struct esme" and put it by the side of the struct definition. https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/892fd606_e03b5193 PS7, Line 330: static int pack_and_send(struct esme *esme, uint32_t type, void *ptr) IIUC this calls can go now to some other file containing "struct esme" APIs. https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/7e0aada6_1c683ad9 PS7, Line 384: static int smpp_handle_gen_nack(struct osmo_esme *esme, struct msgb *msg) this can be probably changed to "struct esme" https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/1f4dc500_2077f7eb PS7, Line 864: osmo_fd_unregister(&esme->esme->wqueue.bfd); THis can be moved to a "struct esme" API in a different file? https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/594105a8_6c8e0bb4 PS7, Line 895: esme->esme->own_seq_nr = rand(); Move to a different "struct esme" API? esme_init() -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28846 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8f7ac2c00d16660925dd0b03aa1a0973edf9eb70 Gerrit-Change-Number: 28846 Gerrit-PatchSet: 7 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Aug 2022 09:17:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment