Attention is currently required from: osmith, pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/31269
)
Change subject: mgcp_e1: be more frugal withe E1 line resources
......................................................................
Patch Set 6:
(1 comment)
File include/osmocom/mgcp/mgcp_trunk.h:
https://gerrit.osmocom.org/c/osmo-mgw/+/31269/comment/0057b4db_5e8639b6
PS5, Line 69: uint8_t ts_in_use[NUM_E1_TS-1];
I first thought this was holding a ts_nr on each array
field. It's actually a counter. […]
I have renamed it now to
"ts_usecount". I think that matches the reality best. The name
"ts_in_use" is from the time where we didn't count the number of used. It
was just a flag to know that this timeslot is already set up so we won't go through
the initialization twice. This is now changed and we properly count the uses of the TS.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/31269
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ie6a32abbc5cd984f6d72a384e3b47c1b82ce7058
Gerrit-Change-Number: 31269
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 22 Feb 2023 12:03:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment