Attention is currently required from: fixeria.

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33417 )

Change subject: PCUIF_Types: fix record PCUIF_pch_dt ......................................................................

Patch Set 1:

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33417/comment/12600845_0498c... PS1, Line 10: it would pad the data with zeros if it does not fit the : specified length. This is unwanted

AFAIR, the `ALIGN` attribute tells where to put the payload if it's less than the buffer size: eithe […]

My observation here is that when ALIGN(left) is used, the buffer is padded with zeros at the beginning. The "ALIGN" behaves more like a "PAD".

With ALIGN(left) the buffer looks like this: 0000000000000000313233343539393837

Without ALIGN(left) (or with ALIGN(right)) the buffer looks like: 3132333435393938370000000000000000 (correct)

Unfortunately I do not fully understand this either. Maybe align in this context is more about padding - I am not sure.

Patchset:

PS1: I have re-tested this, everything seems to be fine but I also didn't fully understand how the ALIGN attribute works (see comment). Since everything works as expected I would say that we can merge this.