Attention is currently required from: fixeria.

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36456?usp=email )

Change subject: msc: rework f_expect_paging(): handle mismatch and timeout ......................................................................

Patch Set 2: Code-Review+1

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36456/comment/f63f9f89_71e06... PS2, Line 13: you could add

Tweaked-by: fixeria

File msc/BSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36456/comment/27c67875_d1c3b... PS2, Line 1362: [g_pars.ran_is_geran] BSSAP.receive(tr_BSSMAP_Paging(g_pars.imsi, tmsi)); (again the weird mix of g_pars.imsi vs not-g_pars tmsi)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36456/comment/c8f8d22d_c3cb0... PS2, Line 1366: function f_expect_paging(template OCT4 tmsi := *, float Tval := 4.0) it would be very elegant if we could have the mechanism that {expects a message, but fails on a different one, and has a timeout} in a more general function, i.e. not specialized for paging in particluar. Then feed a paging PDU template to that.

Then we can use this generalized function all over MSC_Tests.

We have such in HNBGW_Tests.ttcn, like f_rua_expect() f_bssap_expect() Would that work here?

AFAICT we need a separate function for each port-type x PDU-type combination, but not for each message type?

my motivation is for a more generalized approach so that the discussions we had in CR don't come up so much...