Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29524 ) Change subject: osmux: Split input and output code into separate files ...................................................................... Patch Set 1: (7 comments) File src/osmux_input.c: Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-netif-lint-112): https://gerrit.osmocom.org/c/libosmo-netif/+/29524/comment/bcb7c216_ce917ff3 PS1, Line 181: osmuxh->amr_q= 0; spaces required around that '=' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-netif-lint-112): https://gerrit.osmocom.org/c/libosmo-netif/+/29524/comment/cbf8427e_1443446a PS1, Line 373: for (i=1; i<diff; i++) { spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-netif-lint-112): https://gerrit.osmocom.org/c/libosmo-netif/+/29524/comment/4f57d475_7eb937b5 PS1, Line 373: for (i=1; i<diff; i++) { spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-netif-lint-112): https://gerrit.osmocom.org/c/libosmo-netif/+/29524/comment/117827fb_137ffe21 PS1, Line 559: switch(rtph->payload_type) { switch and case should be at the same indent Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-netif-lint-112): https://gerrit.osmocom.org/c/libosmo-netif/+/29524/comment/d5211fcc_3a86b400 PS1, Line 559: switch(rtph->payload_type) { space required before the open parenthesis '(' File src/osmux_output.c: Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-netif-lint-112): https://gerrit.osmocom.org/c/libosmo-netif/+/29524/comment/3acfd949_18b0623d PS1, Line 206: * them for transmission at appropiate time. 'appropiate' may be misspelled - perhaps 'appropriate'? Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-netif-lint-112): https://gerrit.osmocom.org/c/libosmo-netif/+/29524/comment/1b6b9206_24ec5611 PS1, Line 255: if(was_empty && !llist_empty(&h->list)) space required before the open parenthesis '(' -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29524 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia72995092a36ca50147611e617cb88c4dcf231d5 Gerrit-Change-Number: 29524 Gerrit-PatchSet: 1 Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 29 Sep 2022 10:59:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment