Attention is currently required from: pespin.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/31034 )
Change subject: Add setting of Sa bits to misdn driver
......................................................................
Patch Set 6:
(2 comments)
File src/input/misdn.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/31034/comment/95c36455_5e1c692a
PS3, Line 302: uint8_t buffer[sizeof(struct mISDNhead) + sizeof(int)];
Yes, int32_t/uint32_t describes it better, but kernel
still uses (int). I will update this.
Done
https://gerrit.osmocom.org/c/libosmo-abis/+/31034/comment/1b7a9980_b6ed6bd3
PS3, Line 304: int *info = (int *)(buffer + sizeof(struct mISDNhead));
uint32_t?
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/31034
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I54205a2534a7638cc071888d853f9d6d312dc9f0
Gerrit-Change-Number: 31034
Gerrit-PatchSet: 6
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 08 Feb 2023 06:56:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment