Attention is currently required from: pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-cbc/+/32730
)
Change subject: README.md: Document generation of SBcAP code from ASN.1 files
......................................................................
Patch Set 2:
(2 comments)
File README.md:
https://gerrit.osmocom.org/c/osmo-cbc/+/32730/comment/adeb132e_295e86cd
PS1, Line 75: Upstream master as1nc from [
vlm](https://github.com/vlm/asn1c) [doesn't
support APER
encoding](https://github.com/vlm/asn1c/issues/452). Nevertheless, the
upstream fork maintained by a big contributor
[
mouse07410](https://github.com/mouse07410/asn1c) does support it, and it is used in
osmo-cbc to generate the SBc-AP code from ASN.1 files present in src/sbcap/asn1/.
break lines at a similar length as above for
consistency (maybe ~80)?
Done
https://gerrit.osmocom.org/c/osmo-cbc/+/32730/comment/39b95fef_904c88f6
PS1, Line 77: regente
regenerate
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-cbc/+/32730
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: Id6edb2dcbd39ca101110f1ca57fcd67bf08c0ef0
Gerrit-Change-Number: 32730
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 16 May 2023 10:36:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment