Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32915 ) Change subject: immediately SCCP RLSD on HNB re-register ...................................................................... Patch Set 3: (1 comment) File src/osmo-hnbgw/context_map_sccp.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/32915/comment/b6b75d10_d7051683 PS1, Line 362: tx_sccp_df1(fi, ranap_msg); : tx_sccp_rlsd(fi); Any function that implies transmitting a certain packet is named wrong. they do not, which is why they are mis-nomers. The point is that you are *not* requesting the SCCP stack/provider to transmit a certain packet. You are requesting the SCCP stack to terminate a connection. Depending on the internal state of the SCCP stack, and the protocol specification, this *may* trigger a RLSD packet. So unless you reviewed the SCCP state meachines of Q.714 in the last detail, and can prove that no matter what, there will always be a RLSD, the name is wrong. When I wrote the original comment, I stated "I personally don't know the SCCP CO state machines sufficiently off my head". I now did, and it confirms my point all along, A cursory glance of e.g. scoc_fsm_conn_pend_out() shows that SCOC_E_SCU_N_DISC_REQ in this case does not trigger the generation of a RLSD message. Or if you check scoc_fsm_conn_pend_in(), then a SCOC_E_SCU_N_DISC_REQ triggers a SUA CORE packet (which is a CREF in SCCP), and not a RLSD. The SCCP user has no way to send individual protocol messages. This is what protocol stacks are all about. If we wanted the user to implement all the nitty gritty details of SCCP internally, then the user could transmit low-level SCCP packets itself. But it doesn't. It's just a user of the SCCP SAP ("API"), and that API has high-level primitives and not low-level commands to trigger transmission of certain packets. Just like you call close() on a TCP socket. That's what you care about. You don't care about (nor know) if the TCP stack does this with a FIN packet, RST packet or in whatever other magic way. agreed. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32915 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I4e78617ad39bb73fe92097c8a1a8069da6a7f6a1 Gerrit-Change-Number: 32915 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 May 2023 08:19:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment