Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33094 ) Change subject: libosmogsm: Add support for TUAK authentication algorithm ...................................................................... Patch Set 3: (219 comments) File src/gsm/tuak/KeccakP-1600-3gpp.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ce20b9f8_ef772323 PS3, Line 22: EXPORTIT void Keccak_f_8 (uint8_t s[200]); space prohibited between function name and open parenthesis '(' File src/gsm/tuak/KeccakP-1600-3gpp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/748c59bb_d7be1b20 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8d01c63a_81117a47 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/95514046_f160e960 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/06642345_b61b0994 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0db44d3e_3dfb24f5 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3663c743_c8a2466a PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4ba53dbf_e1b5965b PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c4291ed8_a5171e50 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1a58fe50_ed31f461 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f2daf4bd_0162bfa3 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2190d884_e33de024 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e9a73afa_0d0f778c PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/79ec80a0_c413d694 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e425c2e9_c90f1bb2 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bf71cea3_49cbbc85 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2075879c_77990bf8 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/26763efe_acb5236f PS3, Line 13: 15,21,8,18,2,61,56,14}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2289a167_82d28f7b PS3, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3bba4313_9f02ecf2 PS3, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/dd3e9c76_6bffacb6 PS3, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c575dafb_5b8c70cb PS3, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/693e305c_ee070c2e PS3, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c674d0c6_4db736dd PS3, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d81daa34_8bf8b113 PS3, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6d71866e_6b97d53e PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/54eb5ee6_5a977a2f PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5296c42f_ca9b987e PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3e4d82db_90b7875c PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a2112ffc_c5075151 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f0841add_c9662003 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d229772d_c7004f12 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/348ffd53_cb2c39ca PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2b6201a3_170c1e2c PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8aabae08_e05b3e27 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/524a5298_7f4cb226 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7df4c061_e0e05d37 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0406b5d9_c5b6328e PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1516dd28_4979f6a0 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1fa9ec0b_6de3421b PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e0c4c989_1fdb062d PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b97e0ebb_1c8434e9 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4926c8f7_f196e1f2 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5e8baea7_c45c4e25 PS3, Line 16: 23,2,8,14,15,21}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/290a2c0c_27b83e71 PS3, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/01d21db2_629d3d73 PS3, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9b0a297b_7b4a8efa PS3, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cc442ec3_ec96a88b PS3, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/522b574a_0035f84a PS3, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fe583fad_54e59355 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4340ae0e_81ca9326 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c4fe1508_a6e59171 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/158293d7_9ec57c9a PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/566f56d8_0762d193 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/40735d85_6cb42671 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2ebcfa3d_b4056e08 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/73f688fd_2d97b578 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5254767d_a7e5915b PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7fb1ebac_cc049aa4 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/89b4f977_0c2251da PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b02fd15f_9b3decc2 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/484582b1_13f1a3a3 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1c1aeb79_cdf03b9b PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0cbc3a87_56623a97 PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6a752458_4a80b078 PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e5d44d72_80c60fb9 PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fd3a2b25_a9cf8868 PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/27d981e9_37e5590c PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/80717a8c_2ed6c4a1 PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/95e874a9_365335c2 PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9046c63f_f7e376ae PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/dc1a97d1_340138f9 PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5ece5727_60e99b60 PS3, Line 32: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2edc4310_8f8121b5 PS3, Line 32: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e027587f_021920f3 PS3, Line 32: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b1f5cff2_1a1524bb PS3, Line 32: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b3fffc28_01d6b1f2 PS3, Line 34: for(i=0; i<5; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/20ae1865_6bbe8e9e PS3, Line 34: for(i=0; i<5; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6d27a703_5480306c PS3, Line 34: for(i=0; i<5; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c56d9382_ff8ba629 PS3, Line 36: for(i=0; i<5; ++i, s+=5) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b5161f71_76ec241b PS3, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9cf72daf_058d02b3 PS3, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/74d1a8d0_f4e8f77b PS3, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/24ee9d2f_af344c04 PS3, Line 36: for(i=0; i<5; ++i, s+=5) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cb75c622_1e61748c PS3, Line 46: for(i=1; i<25; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/51302a14_aca4b675 PS3, Line 46: for(i=1; i<25; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/dfba9441_8a7d7542 PS3, Line 46: for(i=1; i<25; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/271742ad_16e0a1f0 PS3, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6dd05f66_970f0236 PS3, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/85c81dd0_984c8a12 PS3, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/149f5013_d35539bf PS3, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b522a2fb_814a323e PS3, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/94854510_1d772180 PS3, Line 54: for(i=0; i<5; ++i, s += 5) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/89ae2e39_d16fa701 PS3, Line 54: for(i=0; i<5; ++i, s += 5) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bb8a91dd_315740ae PS3, Line 54: for(i=0; i<5; ++i, s += 5) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8a9ff5f9_d81a40c1 PS3, Line 54: for(i=0; i<5; ++i, s += 5) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/636ffaf7_5f6a857c PS3, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/dcfe5574_ed91d0ab PS3, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/36976244_2a3f5a7d PS3, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/beb7878a_0206cf4b PS3, Line 66: *s ^= (t[0] | (t[0]<<11) | (t[0]<<26) | (t[0]<<57)) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/990aec8e_07df7c6c PS3, Line 67: & 0x800000008000808BULL; /* set & mask bits 0,1,3,7,15,31,63 */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d6f7790f_f633d4f5 PS3, Line 67: & 0x800000008000808BULL; /* set & mask bits 0,1,3,7,15,31,63 */ please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d66b6c16_430c5aa8 PS3, Line 79: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c32933fa_d20b03d7 PS3, Line 79: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8fd8487e_13e15a18 PS3, Line 79: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2de93f7a_0efd3b03 PS3, Line 79: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fa3048a1_7e0474d3 PS3, Line 81: for(i=0; i<40; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/99408108_e5cf9e6a PS3, Line 81: for(i=0; i<40; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ed671200_58f27274 PS3, Line 81: for(i=0; i<40; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/78f1a705_34d3a1dc PS3, Line 82: t[i]=s[i]^s[40+i]^s[80+i]^s[120+i]^s[160+i]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9b88a33d_d7f899db PS3, Line 83: for(i=0; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2f1f1af3_553accf3 PS3, Line 83: for(i=0; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/619ec7b5_e4f7dc01 PS3, Line 83: for(i=0; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/87a044dc_b82c0db8 PS3, Line 83: for(i=0; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8d6a0662_30dd43e2 PS3, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/92a03089_6ae19636 PS3, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7f762ec1_34dd0625 PS3, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6be39f61_d338d67d PS3, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4dac51ce_8dd12616 PS3, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6f0601cf_15db1382 PS3, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6f3ed77e_5730f6f2 PS3, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3e2a6194_d3812cbc PS3, Line 87: for(j = t[i+7]>>7, k=7; k; --k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8ffeb7a7_db301145 PS3, Line 87: for(j = t[i+7]>>7, k=7; k; --k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ddc0397c_7255b61e PS3, Line 89: for(i=0; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6fd9269f_2ea495d8 PS3, Line 89: for(i=0; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e060a9e6_4930b538 PS3, Line 89: for(i=0; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/92ee6d7b_8cfe3bcb PS3, Line 89: for(i=0; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0323d9ce_068b18df PS3, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/368c323f_ab883337 PS3, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9f326a6e_1edc8883 PS3, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0fadd573_ca405dcb PS3, Line 94: for(i=8; i<200; i+=8) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1e59ee07_150f3ca4 PS3, Line 94: for(i=8; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f01ff476_b93d6fae PS3, Line 94: for(i=8; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5fbe56d3_5f2ce6c7 PS3, Line 94: for(i=8; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a21e95c2_6685533c PS3, Line 94: for(i=8; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f25226d4_8a9e9352 PS3, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/94f5cc4e_f9fff415 PS3, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1ad873d2_02bb12b9 PS3, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8126b370_f9f09b43 PS3, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5bcb408d_6ba3dbc1 PS3, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fc6d1881_ac16ce98 PS3, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f7af1db1_2d4add11 PS3, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7433de2f_c350abc4 PS3, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/146fdfd7_6b7102b2 PS3, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9ae5b900_648adeda PS3, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/da31daec_6b174bbe PS3, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c6b0ed87_7e9e6cd2 PS3, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e85b15be_6ea518c0 PS3, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bbfac5a0_7fc3480d PS3, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/586dc61c_3285c983 PS3, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d5fcc0fb_bc571515 PS3, Line 104: for(i=1; (j=Pi[i])>1; i=j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5a79a2f6_5f56d168 PS3, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cd979f60_6f1c4557 PS3, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/257c51ed_2e5cf36b PS3, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/04eb058c_e452ef4b PS3, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7f15da48_1517e492 PS3, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0f1f4bd6_3b5709ba PS3, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/292aac30_dbb23013 PS3, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/62d72607_5c080b8a PS3, Line 111: for(i=0; i<200; i+=40) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c783976e_ab6bd6c0 PS3, Line 111: for(i=0; i<200; i+=40) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a83dd37e_f47b1069 PS3, Line 111: for(i=0; i<200; i+=40) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/73f9fef9_2b988fa5 PS3, Line 111: for(i=0; i<200; i+=40) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c04c19fb_01b2302b PS3, Line 111: for(i=0; i<200; i+=40) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2a090a97_62a737d7 PS3, Line 112: { for(j=0; j<40; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/948f51db_7b76d5d7 PS3, Line 112: { for(j=0; j<40; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/134eee35_959131ee PS3, Line 112: { for(j=0; j<40; ++j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2c786360_637a0ace PS3, Line 113: t[j]=(~s[i+(j+8)%40]) & s[i+(j+16)%40]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c74feb92_6ab679c7 PS3, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/45cd78a7_fec505d1 PS3, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/02a38e47_469723bb PS3, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '^=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/be24c739_1edc6513 PS3, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bb182216_7d624d38 PS3, Line 135: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cb344173_2e89caad PS3, Line 135: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4b39c2f3_ddfe92dd PS3, Line 135: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a91e1735_e07e6927 PS3, Line 135: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4a396235_b04ab51d PS3, Line 137: for(i=0; i<10; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f513c9d6_bd789d6c PS3, Line 137: for(i=0; i<10; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/85f8789a_aef82817 PS3, Line 137: for(i=0; i<10; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/58b08459_3a7bbc43 PS3, Line 139: for(i=0; i<5; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/febf481f_8ccc1cae PS3, Line 139: for(i=0; i<5; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/52984188_f71d7c23 PS3, Line 139: for(i=0; i<5; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4e633b93_677e9bf5 PS3, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d37bbdb3_3e0cf3e6 PS3, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/88f997e4_8f53b012 PS3, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a6327698_2977bc04 PS3, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '%=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a0c74d97_728864ae PS3, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0b22e178_43b4da5f PS3, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/111929ca_0b08799f PS3, Line 143: if(j==8) break; spaces required around that '==' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/79b8bec5_de8772c5 PS3, Line 143: if(j==8) break; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/834fb1d9_2b2ba057 PS3, Line 148: for(i=2; i<50; i+=2) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/954d37f4_14bc9a01 PS3, Line 148: for(i=2; i<50; i+=2) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3f34f8b4_a93db4e9 PS3, Line 148: for(i=2; i<50; i+=2) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6469555f_3dc14f45 PS3, Line 148: for(i=2; i<50; i+=2) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/34d931d8_67d0bb40 PS3, Line 148: for(i=2; i<50; i+=2) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/02d14f36_1b080792 PS3, Line 153: s[i] = t[1-k], s[i+1] = t[k]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8dfc8cb7_b81f2f75 PS3, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/989cef25_0f909383 PS3, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4e990ba0_3aabe9ac PS3, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fca4fe78_54e93de3 PS3, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/925e43a9_dbcda94d PS3, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4575adfa_86ccd7fc PS3, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/dc8be709_c38864c9 PS3, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/671f45a1_9f521cf4 PS3, Line 158: s[i]=s[j], s[i+1]=s[j+1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a9a85c04_5b0d1735 PS3, Line 158: s[i]=s[j], s[i+1]=s[j+1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9b9691cd_1ff7f5bb PS3, Line 158: s[i]=s[j], s[i+1]=s[j+1]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0d847ddf_b3a27b7f PS3, Line 159: s[i]=t[0], s[i+1]=t[1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/71110cad_d06efa9f PS3, Line 159: s[i]=t[0], s[i+1]=t[1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6183f4a5_2f80ed29 PS3, Line 159: s[i]=t[0], s[i+1]=t[1]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e7429dc2_3d8a7f9c PS3, Line 162: for(i=0; i<5; ++i, s+=10) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5fadebb1_96137699 PS3, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d9d0272f_ec71f07a PS3, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d99e7df9_9d7b08fe PS3, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0ba0f6ca_58928afd PS3, Line 162: for(i=0; i<5; ++i, s+=10) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/296d7a1e_a3d47cb1 PS3, Line 163: { for(j=0; j<10; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/41fad1ae_fb37b3f9 PS3, Line 163: { for(j=0; j<10; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/eb490056_44f513ce PS3, Line 163: { for(j=0; j<10; ++j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/63630e2a_824dc03e PS3, Line 165: for(j=0; j<10; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fd103c37_60c1bc98 PS3, Line 165: for(j=0; j<10; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cacf47a7_25fdba5d PS3, Line 165: for(j=0; j<10; ++j) space required before the open parenthesis '(' -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d Gerrit-Change-Number: 33094 Gerrit-PatchSet: 3 Gerrit-Owner: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Comment-Date: Tue, 30 May 2023 14:44:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment