Attention is currently required from: laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35045?usp=email )
Change subject: [WIP] soft_uart: implement OSMO_SUART_RX_MODE_N_FRAMES ......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/core/soft_uart.h:
https://gerrit.osmocom.org/c/libosmocore/+/35045/comment/c08fbed8_b11faf25 PS2, Line 78: number of received UART frames for OSMO_SUART_RX_MODE_N_FRAMES; UART : * will flush receive buffer via the receive call-back after indicated number : * of UART frames had been received. *
how is this different from the existing behavior if you'd simply make the rx buffer size == rx_n_uar […]
I wanted to add an option, eliminating the need for a timer. This is not fully implemented, but the idea was to count not only UART frames containing N bits of data, but also the stop bits (likely applying a lower weight or even separately). So the "takes too long to fill up" problem can be solved by counting stop bits. It was just an idea and I wanted to see how it develops. I will better postpone this for now.