Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35045?usp=email ) Change subject: [WIP] soft_uart: implement OSMO_SUART_RX_MODE_N_FRAMES ...................................................................... Patch Set 2: (1 comment) File include/osmocom/core/soft_uart.h: https://gerrit.osmocom.org/c/libosmocore/+/35045/comment/c08fbed8_b11faf25 PS2, Line 78: number of received UART frames for OSMO_SUART_RX_MODE_N_FRAMES; UART : * will flush receive buffer via the receive call-back after indicated number : * of UART frames had been received. * I wanted to add an option, eliminating the need for a timer. This is not fully implemented, but the idea was to count not only UART frames containing N bits of data, but also the stop bits (likely applying a lower weight or even separately). So the "takes too long to fill up" problem can be solved by counting stop bits. It was just an idea and I wanted to see how it develops. I will better postpone this for now. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35045?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib3249a06c84f3ddb2723d0787db51873c4707d81 Gerrit-Change-Number: 35045 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 17 Nov 2023 16:39:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment