Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/28337 )

Change subject: separate pfcp_queue_timer_cb() in req and resp ......................................................................

Patch Set 1:

(1 comment)

File src/libosmo-pfcp/pfcp_endpoint.c:

https://gerrit.osmocom.org/c/libosmo-pfcp/+/28337/comment/f551d763_0981e139 PS1, Line 285: } else {

You'll probably want to name the 2 timers differently (put them in a union), since anyway you'll wan […]

i don't see a reason to use different timer names. a queue entry is either a request or a response, there will be no double usage, and AFAICT T1 is the name from specs