Attention is currently required from: laforge.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/35640?usp=email )
Change subject: mobile: handle V.24 line status updates from V.110 TA
......................................................................
Patch Set 3:
(1 comment)
File src/host/layer23/src/mobile/tch_data.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/35640/comment/540f71ec_ebfe76da
PS2, Line 210: LOGP(DL1C, LOGL_NOTICE, "V.110 TA circuit %s (%s) is %s\n",
this is something that happens on aregular basis, IMHO
it should be DEBUG and not NOTICE. […]
I agree in genral, but I don't expect the
circuit state to change too often, unless the flow control is employed. Even in the later
case, `LOGL_INFO` should be ok.
See also:
https://gerrit.osmocom.org/c/osmocom-bb/+/35656.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/35640?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I05ba2e10fefe3cae687831b5ced971aa244ad336
Gerrit-Change-Number: 35640
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 22 Jan 2024 21:30:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment