Attention is currently required from: pespin, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31640 ) Change subject: rlcmac: ignore PACKET_DOWNLINK_DUMMY_CONTROL_BLOCK ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/rlcmac/rlcmac.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/31640/comment/5725c405_ddb60426 PS1, Line 392: break; /* Ignore dummy blocks */ (weird place to put a comment IMO, seems to become a habit of yours. comments are good and deserve their own separate line, if nothing else then to keep future patches easier to read.) -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I6a40e2795adc71b9312d39c96b01aba9a258da42 Gerrit-Change-Number: 31640 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Mar 2023 02:35:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment