Attention is currently required from: Hoernchen, fixeria, pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 ) Change subject: ms-trx support ...................................................................... Patch Set 6: (371 comments) File Transceiver52M/ms/bladerf_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cba96288_9dce0497 PS6, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8d1d51b3_c6762930 PS6, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/25d37e61_98e172de PS6, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a0903a4b_431ca2ba PS6, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/471df77d_e79fc628 PS6, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/55699c6f_64f2c2c8 PS6, Line 44: out << '(' << std::forward<Arg>(arg); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f62c4d11_e4febd35 PS6, Line 44: out << '(' << std::forward<Arg>(arg); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b55ad352_2afc71cd PS6, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... }; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/53d6fdc1_b5c02f4e PS6, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... }; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ac3d1010_0ec61331 PS6, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/81c52564_e5e0c48a PS6, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b149cefc_489b30eb PS6, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/32497e3f_da9c54fd PS6, Line 52: template <class R, class... Args> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78de4a78_0bcb92d0 PS6, Line 52: template <class R, class... Args> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5b41b3d9_70312b1f PS6, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6db09a32_135c28cc PS6, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line, spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5ee28079_3fe43447 PS6, Line 56: R rval = func(std::forward<Args>(args)...); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/34229a71_2bfd7053 PS6, Line 56: R rval = func(std::forward<Args>(args)...); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4d66312e_561fb4d0 PS6, Line 57: if (rval != 0) { suspect code indent for conditional statements (8, 26) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dc127de6_2dd3de18 PS6, Line 58: std::cerr << ((rval >= 0) ? "OK:" : bladerf_strerror(rval)) << ':' << finame << ':' << line << ':' labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d2163349_ea55f7eb PS6, Line 66: #define blade_check(func, ...) exec_and_check(func, #func, __FILE__, __FUNCTION__, __LINE__, __VA_ARGS__) __func__ should be used instead of gcc specific __FUNCTION__ Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d7e0c130_d17324a6 PS6, Line 69: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d91f638a_bfb75738 PS6, Line 69: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/657e8298_83727563 PS6, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ee2cbfd5_003c31ad PS6, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9b1cbbf3_ed75114f PS6, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!"); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4ab976ad_8c87c642 PS6, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!"); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c2f0524c_981751d3 PS6, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!"); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1cc71692_1b6dcea2 PS6, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!"); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cfada22b_e7e35263 PS6, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/65b91c83_1039a837 PS6, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/71e0259c_2c230477 PS6, Line 82: blade_usb_message<T> m[SZ]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/905e3e6a_f2743c56 PS6, Line 82: blade_usb_message<T> m[SZ]; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4d269edf_dab745d8 PS6, Line 83: int actual_samples_per_msg() Bad function definition - int actual_samples_per_msg() should probably be int actual_samples_per_msg(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b54fffe1_404dc763 PS6, Line 83: int actual_samples_per_msg() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d4e3c569_cc203e79 PS6, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/52b21967_ddb2ae1a PS6, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bd81ccb9_41faed84 PS6, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7fefd873_d8350277 PS6, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2d54de89_24f31959 PS6, Line 87: int actual_samples_per_buffer() Bad function definition - int actual_samples_per_buffer() should probably be int actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fbb902f9_3da22c9a PS6, Line 87: int actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2055f44b_db08d306 PS6, Line 91: int samples_per_buffer() Bad function definition - int samples_per_buffer() should probably be int samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/75552cde_464cc0b9 PS6, Line 91: int samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aa2b6488_ec18b9b2 PS6, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f0b94cd2_0a40a622 PS6, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cc90305b_979893bf PS6, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f70892e3_5b2285b3 PS6, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0975a1b5_633b153c PS6, Line 95: int num_msgs_per_buffer() Bad function definition - int num_msgs_per_buffer() should probably be int num_msgs_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0442262b_cd8fb023 PS6, Line 95: int num_msgs_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d83e7237_087a40c2 PS6, Line 99: auto get_first_ts() Bad function definition - auto get_first_ts() should probably be auto get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9ff51800_779cb767 PS6, Line 99: auto get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c333eb97_fd6f2308 PS6, Line 103: constexpr auto *getsampleoffset(int ofs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b9736d8b_496b541f PS6, Line 109: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d8accf92_54cd12bc PS6, Line 118: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/941e737b_68a529f8 PS6, Line 156: int write_n_burst(blade_sample_type *in, int num, uint64_t first_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8317453_b07b36bd PS6, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7db15612_aa8ff5a9 PS6, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4f37419f_72cbc78a PS6, Line 178: static blade_otw_buffer<SZ / 512, T> x; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1f8b8efd_9c354011 PS6, Line 178: static blade_otw_buffer<SZ / 512, T> x; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/436424e7_354ba92b PS6, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1fae6399_8f8b0988 PS6, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b604ce0a_28dee8c0 PS6, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c6c536f2_63b055c7 PS6, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8de830a1_c0475772 PS6, Line 185: template <typename T> struct blade_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e0e9bc6c_d6bb958c PS6, Line 185: template <typename T> struct blade_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d940f4ac_b68d06b7 PS6, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/86a06f6c_e424f89b PS6, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5bd0fd3a_048e384a PS6, Line 202: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8091cf7_a4acd099 PS6, Line 223: void close_device() Bad function definition - void close_device() should probably be void close_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3059272_d2a2c781 PS6, Line 223: void close_device() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5b94ec70_7848e6df PS6, Line 242: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cc8f26de_b5688b1c PS6, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ff2a4505_281cd94f PS6, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a7a69449_98d7c119 PS6, Line 250: std::cerr << "open failed, device missing?" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f023d650_02928eb2 PS6, Line 254: std::cerr << "open failed, only superspeed (usb3) supported!" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fe698eec_222ad3dc PS6, Line 271: std::cerr << "unable to lock refclk!" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/388043c8_0b1fcea9 PS6, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f2713fe4_40d1af62 PS6, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9fad722d_71cb2f14 PS6, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b30de08b_01da6ece PS6, Line 316: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/40ba209d_9c566216 PS6, Line 318: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b351ad4a_eca553b4 PS6, Line 320: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fa73b5b5_a6788cf3 PS6, Line 323: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1be76719_369715d4 PS6, Line 325: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3918d545_588be2a5 PS6, Line 327: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/946fd9f2_ae34a3c8 PS6, Line 330: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/062369e9_71b3160c PS6, Line 335: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/10dc3333_2daa4407 PS6, Line 338: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/048d917b_3f8e3fcb PS6, Line 340: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/feae2ef0_1a38e50f PS6, Line 343: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7855d565_de164539 PS6, Line 346: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/34472239_f177fea9 PS6, Line 348: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5eb6bbca_599483f5 PS6, Line 351: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f967a43e_c788ff5f PS6, Line 356: static void check_timestamp(dev_buf_t *rcd) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c346b215_fcc2cac3 PS6, Line 363: } else if (last_ts + rcd->actual_samples_per_buffer() != rcd->m[0].ts) { suspect code indent for conditional statements (16, 34) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2bda0d5c_c74d40a0 PS6, Line 364: std::cerr << "RX Overrun!" << last_ts << " " << rcd->actual_samples_per_buffer() << " " labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e5cdcec2_9eef7a54 PS6, Line 372: bladerf_stream_cb getrxcb(bh_fn_t rxbh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7c6b7b83_ffab0fce PS6, Line 376: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta, space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e4d43eec_c9399460 PS6, Line 377: void *samples, size_t num_samples, void *user_data) -> void * { spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/491c98b5_2be33eea PS6, Line 392: bladerf_stream_cb gettxcb(bh_fn_t txbh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6d3dca8f_c4644e30 PS6, Line 396: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta, space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cf10dc11_a7e1b06a PS6, Line 397: void *samples, size_t num_samples, void *user_data) -> void * { spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/81a2a349_c139c214 PS6, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/489953e6_33e737eb PS6, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7e130c9e_13a4c4ec PS6, Line 408: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/727389fe_7b35f34f PS6, Line 410: auto fn = [this] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1e040540_9f77a183 PS6, Line 414: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9943c310_3a7da131 PS6, Line 420: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a7b11163_699f2c91 PS6, Line 422: auto fn = [this] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/de238cd4_20cc94f4 PS6, Line 426: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d7807fa4_fb03f944 PS6, Line 433: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ff6ad63c_74808de8 PS6, Line 435: //get empty bufer from list 'bufer' may be misspelled - perhaps 'buffer'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fcfa3458_43b4d950 PS6, Line 436: tx_buf_q_type::elem_t rcd; labels should not be indented File Transceiver52M/ms/itrq.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a29388ad_1788e1f3 PS6, Line 36: template <bool block_read, bool block_write> class spsc_cond_detail { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/039741d2_a086eb7a PS6, Line 36: template <bool block_read, bool block_write> class spsc_cond_detail { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/79471251_9b612d3a PS6, Line 37: std::condition_variable cond_r, cond_w; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7af86c10_ee7e81fd PS6, Line 38: std::mutex lr, lw; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d8753d8b_6abb2165 PS6, Line 39: std::atomic_int r_flag, w_flag; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/97d6a01e_ae384ecc PS6, Line 41: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/988d8d3e_e2167834 PS6, Line 42: explicit spsc_cond_detail() : r_flag(0), w_flag(0) Bad function definition - explicit spsc_cond_detail() should probably be explicit spsc_cond_detail(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8c537d30_83adf7d5 PS6, Line 50: ssize_t spsc_check_r() Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/acd814af_306fa636 PS6, Line 50: ssize_t spsc_check_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1c13b7aa_2fbfe059 PS6, Line 52: std::unique_lock<std::mutex> lk(lr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/db761f19_6bdae3dc PS6, Line 52: std::unique_lock<std::mutex> lk(lr); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/db4aa390_69a666c1 PS6, Line 52: std::unique_lock<std::mutex> lk(lr); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5b028512_33358adb PS6, Line 58: ssize_t spsc_check_w() Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/62ea9dde_cf3d636d PS6, Line 58: ssize_t spsc_check_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/96177c1f_911dde78 PS6, Line 60: std::unique_lock<std::mutex> lk(lw); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d5c91766_eb48d734 PS6, Line 60: std::unique_lock<std::mutex> lk(lw); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/971d78a7_13b198bc PS6, Line 60: std::unique_lock<std::mutex> lk(lw); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b557948a_f30ac127 PS6, Line 66: void spsc_notify_r() Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b2318bdc_8f299bbd PS6, Line 66: void spsc_notify_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f2c7570d_c3deecd5 PS6, Line 68: std::unique_lock<std::mutex> lk(lr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bc12d860_30f19824 PS6, Line 68: std::unique_lock<std::mutex> lk(lr); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f2d53df1_fb2afa5f PS6, Line 68: std::unique_lock<std::mutex> lk(lr); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ea8a9ea2_e0f0780a PS6, Line 72: void spsc_notify_w() Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c82e90b4_ee707673 PS6, Line 72: void spsc_notify_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7171b97f_37f51c79 PS6, Line 74: std::unique_lock<std::mutex> lk(lw); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a268b1ac_ae31e369 PS6, Line 74: std::unique_lock<std::mutex> lk(lw); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/547c9c5c_50aff220 PS6, Line 74: std::unique_lock<std::mutex> lk(lw); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7bc877c8_8f685ca9 PS6, Line 81: template <bool block_read, bool block_write> class spsc_efd_detail { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/71e27a2a_c9722111 PS6, Line 81: template <bool block_read, bool block_write> class spsc_efd_detail { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9b7d66e0_e5838a50 PS6, Line 84: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/664e80db_d7230f92 PS6, Line 85: explicit spsc_efd_detail() Bad function definition - explicit spsc_efd_detail() should probably be explicit spsc_efd_detail(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4103b852_7aee46ed PS6, Line 96: ssize_t spsc_check_r() Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f1483967_ebe9c559 PS6, Line 96: ssize_t spsc_check_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/99e7aa91_424e76f5 PS6, Line 101: ssize_t spsc_check_w() Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f87ba9a_8b4ab82f PS6, Line 101: ssize_t spsc_check_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/23201d62_4a30a493 PS6, Line 106: void spsc_notify_r() Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8157c50d_9542c0a3 PS6, Line 106: void spsc_notify_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/553e8cba_97f11643 PS6, Line 111: void spsc_notify_w() Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d1fbf5dd_bf09ea44 PS6, Line 111: void spsc_notify_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1ac053e4_f0ece2e0 PS6, Line 116: int get_r_efd() Bad function definition - int get_r_efd() should probably be int get_r_efd(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/44166ec1_634d229b PS6, Line 116: int get_r_efd() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e3b7ef81_5de350ae PS6, Line 120: int get_w_efd() Bad function definition - int get_w_efd() should probably be int get_w_efd(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/242aff6c_77f55443 PS6, Line 120: int get_w_efd() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f9bf9d5c_fcd35f77 PS6, Line 126: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5618a8b6_30847f3a PS6, Line 126: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f914c5de_cb8b0fe3 PS6, Line 126: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cc00b7d5_5db13c6b PS6, Line 126: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b7811d0a_5ee6108f PS6, Line 127: class spsc : public T<block_read, block_write> { spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/38c12bb0_81530c27 PS6, Line 127: class spsc : public T<block_read, block_write> { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/813d72ec_8aa86e08 PS6, Line 129: std::atomic<unsigned int> readptr; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/70a3e52e_4b51bd33 PS6, Line 129: std::atomic<unsigned int> readptr; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a387b7de_53cbf6a9 PS6, Line 129: std::atomic<unsigned int> readptr; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/daf22bd4_2fd98762 PS6, Line 130: std::atomic<unsigned int> writeptr; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/747fbe92_6f0e6fc0 PS6, Line 130: std::atomic<unsigned int> writeptr; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d76f6f79_93d79e36 PS6, Line 130: std::atomic<unsigned int> writeptr; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0e1c7ca9_443847e6 PS6, Line 134: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e585ab69_5f53030a PS6, Line 135: using base_t = T<block_read, block_write>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5afc2b02_e5150bf7 PS6, Line 135: using base_t = T<block_read, block_write>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c80d1824_efa77a3e PS6, Line 137: explicit spsc() : readptr(0), writeptr(0) Bad function definition - explicit spsc() should probably be explicit spsc(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6a4eef46_ec1ea710 PS6, Line 148: bool spsc_push(const ELEM *elem) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/01284e7a_22219f64 PS6, Line 155: base_t::spsc_check_w(); /* blocks, ensures next (!) call succeeds */ labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7817b604_bcebed8c PS6, Line 161: base_t::spsc_notify_r(); /* fine after release */ labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cb90f315_48195a78 PS6, Line 168: bool spsc_pop(ELEM *elem) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0051a078_c5bf369a PS6, Line 180: base_t::spsc_notify_w(); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b618b9a8_0d0e8339 PS6, Line 187: ssize_t spsc_prep_pop() Bad function definition - ssize_t spsc_prep_pop() should probably be ssize_t spsc_prep_pop(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aad1abc3_bdd74fb2 PS6, Line 187: ssize_t spsc_prep_pop() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6dbee5e7_aa7781df PS6, Line 195: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/de6d9810_d533785c PS6, Line 195: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3add248c_eedc16c7 PS6, Line 196: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {}; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ef03e157_311dac1c PS6, Line 196: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {}; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7adb700c_aaba18fe PS6, Line 197: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3bbc5591_6edcd349 PS6, Line 197: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/21045e70_7b7eb48d PS6, Line 198: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; adding a line without newline at end of file Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/086dc391_6cab7129 PS6, Line 198: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0adec67f_254f141c PS6, Line 198: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; spaces required around that '>' (ctx:VxW) File Transceiver52M/ms/ms.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aabd2f56_f8b80ac1 PS6, Line 33: #define BASET blade_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a6c6a018_7a9bfc73 PS6, Line 33: #define BASET blade_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/24182d19_13056b6c PS6, Line 36: #define BASET uhd_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5b410f1a_3b247724 PS6, Line 36: #define BASET uhd_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8f06b89c_5f91d244 PS6, Line 48: template <typename T> void clamp_array(T *start2, unsigned int len, T max) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c154b201_8d989127 PS6, Line 48: template <typename T> void clamp_array(T *start2, unsigned int len, T max) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/38e7331b_ac1f1ab4 PS6, Line 48: template <typename T> void clamp_array(T *start2, unsigned int len, T max) need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ca83a806_66298916 PS6, Line 56: template <typename DST_T, typename SRC_T, typename ST> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/af7ea9a2_6561c7a7 PS6, Line 56: template <typename DST_T, typename SRC_T, typename ST> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0353a206_a9c30767 PS6, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/202809e5_1a86b7b3 PS6, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/abddab6f_0fc7e581 PS6, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fa3a44a4_72a5abf9 PS6, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6276ade7_abcaaca7 PS6, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b5fd2a59_3c67435e PS6, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b98c0b0e_b8563458 PS6, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3961ec9_3ff6f817 PS6, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4afc5a8f_a7adefa3 PS6, Line 62: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6964ed18_4e61d606 PS6, Line 62: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/278eacb0_1769ff10 PS6, Line 64: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e3922d7b_4f409e42 PS6, Line 64: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bb213cdc_37858161 PS6, Line 71: GSM::Time gsmts; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ca7e3485_5750be6a PS6, Line 78: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/de9c69dc_1c300a99 PS6, Line 78: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fca66622_4b718eb5 PS6, Line 83: std::ostream null_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/266472b2_1e3324e7 PS6, Line 85: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a37d882a_b7148af9 PS6, Line 86: dummylog() : null_stream(this){}; space required before the open brace '{' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a414c5bb_6f93e9f5 PS6, Line 88: std::ostream &operator()() need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8478dc35_784411bf PS6, Line 88: std::ostream &operator()() labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1f55c298_7bf7c2b7 PS6, Line 100: GSM::Time global_time_keeper; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d9b0dc85_2c8f53df PS6, Line 102: std::mutex m; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cc3860ab_d5d51699 PS6, Line 104: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c40f0a14_ca39503d PS6, Line 109: void set(GSM::Time t, int64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1ea8efa1_f6ac130f PS6, Line 111: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dc2b16e6_4a47f2e6 PS6, Line 111: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2bd25a25_68ae29e6 PS6, Line 111: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4c4e8034_09926687 PS6, Line 115: void inc_both() Bad function definition - void inc_both() should probably be void inc_both(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/58f8b6f8_80383c15 PS6, Line 115: void inc_both() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0b7bafde_204242b7 PS6, Line 117: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4aeca82a_cffcecde PS6, Line 117: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dbacacb9_a07f3e85 PS6, Line 117: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/af379881_0ff2f42c PS6, Line 121: void inc_and_update(int64_t new_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dbbc8b69_1765d643 PS6, Line 123: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1f77533f_28580f68 PS6, Line 123: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a59a078a_54793ebf PS6, Line 123: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fff1aeaa_408ef5f7 PS6, Line 128: void inc_and_update_safe(int64_t new_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/80436c1e_1a5dad6d PS6, Line 130: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8c181b52_8b12fa26 PS6, Line 130: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3f3945eb_d87df95d PS6, Line 130: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8d5c2e51_94129f59 PS6, Line 138: void dec_by_one() Bad function definition - void dec_by_one() should probably be void dec_by_one(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/005cfb0d_66b5f930 PS6, Line 138: void dec_by_one() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9005aee1_17f56946 PS6, Line 140: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/62409a4b_174fd0ff PS6, Line 140: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5ee783ee_7e4a5cf9 PS6, Line 140: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/82d7d841_d5c69cc2 PS6, Line 144: auto get_ts() Bad function definition - auto get_ts() should probably be auto get_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a0660436_b6335c5a PS6, Line 144: auto get_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/81ef3c13_40fadc43 PS6, Line 146: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/59d7ad98_3a0b1081 PS6, Line 146: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/97aeb5bc_dc089dd3 PS6, Line 146: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8f80cebe_c3cc031d PS6, Line 149: auto gsmtime() Bad function definition - auto gsmtime() should probably be auto gsmtime(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/700f501b_32456309 PS6, Line 149: auto gsmtime() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6af43d27_291693e9 PS6, Line 151: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bd4af034_d7abce06 PS6, Line 151: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e12eb18e_12646652 PS6, Line 151: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6602e86a_a536fe8f PS6, Line 154: void get_both(GSM::Time *t, int64_t *ts) need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e6ffefc2_7b9e6e9f PS6, Line 154: void get_both(GSM::Time *t, int64_t *ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a7b1a934_535f375b PS6, Line 156: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fe8348c2_564956e3 PS6, Line 156: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0fdba3db_ee18cad9 PS6, Line 156: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/268bc26b_d40fd5c7 PS6, Line 162: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/81c97e70_4d1ad1a4 PS6, Line 162: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bccaf7a3_9d9f0b51 PS6, Line 172: std::thread rx_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/62a8228f_11a3bd67 PS6, Line 173: std::thread tx_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/73bf3aa1_242efc97 PS6, Line 174: std::thread *calcrval_task; need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/54f311ee_221233fd PS6, Line 174: std::thread *calcrval_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d73d6868_84e2dd11 PS6, Line 185: std::atomic<bool> rcv_done; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/09b7a19c_06b7925a PS6, Line 185: std::atomic<bool> rcv_done; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9356e2ba_3b6c7b01 PS6, Line 185: std::atomic<bool> rcv_done; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5fb79ef1_065b99fc PS6, Line 186: std::atomic<bool> sch_thread_done; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bd2cd2ee_d419d019 PS6, Line 186: std::atomic<bool> sch_thread_done; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f794cc71_54e14633 PS6, Line 186: std::atomic<bool> sch_thread_done; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1a4af714_15e9dd7b PS6, Line 193: void start(); Bad function definition - void start() should probably be void start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ba7ccaf1_c30e8f13 PS6, Line 194: std::atomic<bool> upper_is_ready; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6d8bc1ea_a89ce24c PS6, Line 194: std::atomic<bool> upper_is_ready; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bbc15084_0d9e00f6 PS6, Line 194: std::atomic<bool> upper_is_ready; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fcd66333_faea158e PS6, Line 197: bool handle_sch_or_nb(); Bad function definition - bool handle_sch_or_nb() should probably be bool handle_sch_or_nb(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6539a9bf_e1bd5b2a PS6, Line 203: int init_device(); Bad function definition - int init_device() should probably be int init_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7baefb60_17357e54 PS6, Line 204: int init_dev_and_streams(); Bad function definition - int init_dev_and_streams() should probably be int init_dev_and_streams(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f48f516c_c47457dd PS6, Line 205: void stop_threads(); Bad function definition - void stop_threads() should probably be void stop_threads(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3ee18b1_81e4e074 PS6, Line 207: void *tx_cb(); Bad function definition - void *tx_cb() should probably be void *tx_cb(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c483501e_e4a5f31c PS6, Line 208: void maybe_update_gain(one_burst &brst); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a08fc80a_d458bc4b PS6, Line 221: bh_fn_t rx_bh(); Bad function definition - bh_fn_t rx_bh() should probably be bh_fn_t rx_bh(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5e056e28_79d321dc PS6, Line 222: bh_fn_t tx_bh(); Bad function definition - bh_fn_t tx_bh() should probably be bh_fn_t tx_bh(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6091b9f0_4a2a52e4 PS6, Line 225: void set_ta(int val) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5506bacb_6020f7c2 PS6, Line 231: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/02c59c0d_b5e7d9c3 PS6, Line 236: void set_name_aff_sched(std::thread::native_handle_type h, const char *name, int cpunum, int schedtype, open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5cdd81cc_411cd696 PS6, Line 248: std::cerr << name << " affinity: errreur! " << std::strerror(errno); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7ffec83e_bab1960c PS6, Line 256: std::cerr << name << " sched: errreur! " << std::strerror(errno); labels should not be indented File Transceiver52M/ms/ms_rx_burst.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/53dc95d2_c885c716 PS6, Line 25: void rcv_bursts_test(rx_queue_t *q, unsigned int *tsc, int scale); adding a line without newline at end of file File Transceiver52M/ms/ms_upper.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3198fc8e_d2d02d78 PS6, Line 36: bool driveControl(); Bad function definition - bool driveControl() should probably be bool driveControl(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4a7cc801_f34d9b2c PS6, Line 37: void driveReceiveFIFO(); Bad function definition - void driveReceiveFIFO() should probably be void driveReceiveFIFO(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fddf8215_6237fdbf PS6, Line 38: void driveTx(); Bad function definition - void driveTx() should probably be void driveTx(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/857063dc_561f5921 PS6, Line 40: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c9b40fdc_e9a970f1 PS6, Line 40: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ea0ef336_c2733adb PS6, Line 40: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bb9891db_b8e976dd PS6, Line 40: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); function definition argument 'int' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/76442e29_e5106f47 PS6, Line 40: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); function definition argument 'int' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8d1edaf1_a8e7f502 PS6, Line 42: std::thread thr_control, thr_rx, thr_tx; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2a557da9_abd7772a PS6, Line 44: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/790bfda7_a56da167 PS6, Line 45: void start_threads(); Bad function definition - void start_threads() should probably be void start_threads(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b275fe28_f1dfd835 PS6, Line 46: void start_lower_ms(); Bad function definition - void start_lower_ms() should probably be void start_lower_ms(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/70c11c4c_8e5626e1 PS6, Line 48: upper_trx(){}; space required before the open brace '{' File Transceiver52M/ms/sch.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5f5da8f5_6c744cb6 PS6, Line 130: int gsm_fcch_check_ts(int ts, int fn) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/50a264d5_9ac90d45 PS6, Line 134: int gsm_sch_check_ts(int ts, int fn) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/608e93bd_6279e4b5 PS6, Line 205: #if 1 Consider removing the #if 1 and its #endif Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/db86b22e_8bc13039 PS6, Line 210: float a, b, c, d, ang, avg = 0.0f; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1fb1de63_aee6fae5 PS6, Line 235: ang = b - a; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/857c6fc6_e21f06c4 PS6, Line 237: if (ang > M_PI) 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/785e7c1f_c7f042bb PS6, Line 238: ang -= 2 * M_PI; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7de4eaaa_602b4138 PS6, Line 239: else if (ang < -M_PI) 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7ee918e9_cdace659 PS6, Line 240: ang += 2 * M_PI; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d12c9c2c_e2dffe7e PS6, Line 242: avg += ang; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/23c1391f_fe22a20e PS6, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/acc4e227_81ff7d88 PS6, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ec249932_5c4ab4f0 PS6, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3c9547f9_e4684820 PS6, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d0c667d9_7d335eb1 PS6, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/effa5f1e_9e501d58 PS6, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/97712f84_4bea3aed PS6, Line 314: static __attribute__((constructor)) void init() Bad function definition - void init() should probably be void init(void) File Transceiver52M/ms/uhd_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f11ce328_a976616d PS6, Line 35: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a372a5b5_e7d6b846 PS6, Line 35: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/91458011_6e2447c9 PS6, Line 41: uhd::rx_metadata_t *md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4458cdeb_79630a1f PS6, Line 43: auto actual_samples_per_buffer() Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/edad5b21_d1a5bb2d PS6, Line 43: auto actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8327e8d6_4c65d355 PS6, Line 47: long get_first_ts() Bad function definition - long get_first_ts() should probably be long get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e26b73d8_d86ac39d PS6, Line 47: long get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/87ef8401_807c82ad PS6, Line 51: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5b911fc3_aa920070 PS6, Line 56: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/969e4517_46aaba86 PS6, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c0f38f84_ad73ec0d PS6, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/adb1f7a1_1a954b5e PS6, Line 69: template <typename T> struct uhd_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/276c1887_ad536667 PS6, Line 69: template <typename T> struct uhd_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1a112886_c435b977 PS6, Line 70: uhd::usrp::multi_usrp::sptr dev; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/33a086ea_fe66b89d PS6, Line 71: uhd::rx_streamer::sptr rx_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/588124db_2abd5448 PS6, Line 72: uhd::tx_streamer::sptr tx_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d6c5cd05_65f18271 PS6, Line 74: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/913ba2c0_9880b4d3 PS6, Line 74: std::vector<blade_sample_type *> pkt_ptrs; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/919ae3e0_edf6a156 PS6, Line 74: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/784634db_6d215ada PS6, Line 74: std::vector<blade_sample_type *> pkt_ptrs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3e443775_1cea5498 PS6, Line 90: void close_device() Bad function definition - void close_device() should probably be void close_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8224cb34_43f42bfc PS6, Line 90: void close_device() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/954955be_657cf468 PS6, Line 95: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6738d806_9a6bfd7e PS6, Line 102: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b58e969c_f22558f0 PS6, Line 109: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c212a283_a7541cc1 PS6, Line 114: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b6dc20a2_6f595403 PS6, Line 122: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2498c61a_8595f999 PS6, Line 130: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5fe50f21_c00270d2 PS6, Line 135: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f6af5c5_ee458f0c PS6, Line 145: std::string args = {}; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e020eccf_bb62aad6 PS6, Line 148: std::cout << "Using Device: " << dev->get_pp_string() << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fc13c022_4fed2ce8 PS6, Line 153: uhd::tune_request_t tune_request(freq, 0); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b7513d6d_e5f6443a PS6, Line 162: std::this_thread::sleep_for(std::chrono::milliseconds(lock_delay_ms)); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/87e6b7a2_5908b545 PS6, Line 164: uhd::stream_args_t stream_args("sc16", "sc16"); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8a79cf13_7523ae2a PS6, Line 166: uhd::stream_args_t stream_args2("sc16", "sc16"); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5e9948fe_873d13ba PS6, Line 177: void *rx_cb(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a2d92878_3657d474 PS6, Line 182: uhd::rx_metadata_t md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4145ce7b_37972418 PS6, Line 186: std::cerr << boost::format("Timeout while streaming") << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9d0a85d5_74d95d07 PS6, Line 190: std::cerr << boost::format("Got an overflow indication\n") << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9e6fad3c_25b85166 PS6, Line 194: std::cerr << str(boost::format("Receiver error: %s") % md.strerror()); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3cb30a7d_a4d8dc7c PS6, Line 209: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a862571e_899e216d PS6, Line 211: auto fn = [this, burst_handler] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/22ae16cf_d07b8cd9 PS6, Line 214: uhd::stream_cmd_t stream_cmd(uhd::stream_cmd_t::STREAM_MODE_START_CONTINUOUS); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/66b9b1a4_1ed5ccb4 PS6, Line 225: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b591fa6c_649e0009 PS6, Line 227: auto fn = [] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f0efd7ab_f0112210 PS6, Line 232: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e289741c_964a3b42 PS6, Line 234: uhd::tx_metadata_t m = {}; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a20381d0_2ced6977 PS6, Line 239: std::vector<void *> ptrs(1, buffer); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/edf8e47d_1a1e30af PS6, Line 239: std::vector<void *> ptrs(1, buffer); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fc591742_f8d5e854 PS6, Line 239: std::vector<void *> ptrs(1, buffer); spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8c3dbf3a_763a599a PS6, Line 239: std::vector<void *> ptrs(1, buffer); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d2308aad_624203f6 PS6, Line 243: uhd::async_metadata_t async_md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2c492a56_0d578a64 PS6, Line 248: std::cout << (tx_ack ? "yay" : "nay") << " " << async_md.time_spec.to_ticks(rxticks) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6b15b834_c5d08468 PS6, Line 251: }; adding a line without newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Comment-Date: Fri, 02 Dec 2022 12:42:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment