Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/40187?usp=email ) Change subject: vty: remove broken 'show startup-config' command ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/40187/comment/46cf8e4d_8390990f?… : PS1, Line 9: Saving the current configuration by doing 'write file [FILE]' breaks : the 'show startup-config' command. If write succeeds, this command : will be showing contents of the new (potentially modified) file. this is exactly how it would behave on a cisco device, isn't it? If you write to the file (basically `copy running-config startup-config`, then the [next] startup config is exactly the same as what you're running right now. I don't see a bug here. https://gerrit.osmocom.org/c/libosmocore/+/40187/comment/81449ac8_285ba68d?… : PS1, Line 12: If Doesn't that mean that the write is then broken? The write should probably always write to a newly-created file, and only after that succeeds unlink the old file and rename the new file, to ensure we always have either the old (unsuccesful write) or the new (successful write) config. If there is a related bug, it should be fixed in the write, and not worked around here? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40187?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If0b4a79052c060cad963e6458b29000a979f95ba Gerrit-Change-Number: 40187 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 May 2025 07:29:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No