Attention is currently required from: neels.

jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33504 )

Change subject: ASCI: Add function to receive VGCS/VBS messages from BSS ......................................................................

Patch Set 15:

(2 comments)

File src/libmsc/ran_peer.c:

https://gerrit.osmocom.org/c/osmo-msc/+/33504/comment/703525ee_2c282e64 PS14, Line 396:

so below, there is a priority: 1.msc_role 2.vgcs.bss 3.vgcs.cell. […]

A conn that is used for VGCS/VBS BSS connection (conn->vgcs.bss) and a conn that is used for VGCS/VBS channel connection (conn->vgcs.cell) does not have any transaction, nor subscriber. Both connection types are linked as sub structures to a VGCS/VBS transaction. (using lists) The VGCS/VBS transaction uses conn->msc_role until the caller is assigned to the VGCS/VBS channel. As said above, this channel (the caller is assigned to) has no transaction, nor subscriber linked to it, even if someone (the caller or other subscriber) is talking on the channel.

https://gerrit.osmocom.org/c/osmo-msc/+/33504/comment/16549405_5b13b2ad PS14, Line 413: return

(now redundant)

Done