Attention is currently required from: neels.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32716 )
Change subject: fix missing write-back of rnc-id
......................................................................
Patch Set 4:
(1 comment)
File src/osmo-hnbgw/hnbgw_vty.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32716/comment/fe65ae38_21c79160
PS4, Line 423: vty_out(vty, " rnc-id %u%s", g_hnbgw->config.rnc_id,
VTY_NEWLINE);
I think rnc-id sounds more important and hence should probably be put before timers and
logging related stuff. What do you think?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32716
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ide006379b26949e34371bd316a22c130ea09da82
Gerrit-Change-Number: 32716
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 16 May 2023 12:36:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment