Attention is currently required from: fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32926 ) Change subject: mgcp_codec: be sensitive about IuFP when checking codecs ...................................................................... Patch Set 1: (2 comments) File src/libosmo-mgcp/mgcp_codec.c: https://gerrit.osmocom.org/c/osmo-mgw/+/32926/comment/45b56767_fc09f8ce PS1, Line 336: /* In 3G IuUP AMR may be encapsulated in IuFP, this means even though the codec name and negotiated rate is "In 3G IuUP, AMR" (missing comma). https://gerrit.osmocom.org/c/osmo-mgw/+/32926/comment/c9a78260_20fb826c PS1, Line 344: if (!iufp && strcmp(codec_a->subtype_name, codec_b->subtype_name)) this may be cleaner with a goto to line 346, instead of insturdicing the "iufp" flag. As you prefer. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32926 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6bc1e6022efe21cb893ef213f3da35017960357d Gerrit-Change-Number: 32926 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 May 2023 12:18:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment