neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27254 ) Change subject: allow to terminate value_string[] with '{0}' ...................................................................... allow to terminate value_string[] with '{0}' For a long time I was using '{}' to indicate a nulled out struct. But apparently '{0}' is the favored way to write that. Let's allow using this notation to terminate a value_string[]. Change-Id: Id2f5ba897ec83f34f8d3c4425353c0baf309bb6d --- M scripts/verify_value_string_arrays_are_terminated.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: neels: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/scripts/verify_value_string_arrays_are_terminated.py b/scripts/verify_value_string_arrays_are_terminated.py index f6dc545..abeff4d 100755 --- a/scripts/verify_value_string_arrays_are_terminated.py +++ b/scripts/verify_value_string_arrays_are_terminated.py @@ -19,7 +19,7 @@ re.MULTILINE | re.DOTALL) members = r'(\.(value|str)\s*=\s*)?' -terminator_re = re.compile('{}|{\s*' + members + '(0|NULL)\s*,' +terminator_re = re.compile('{\s*}|{\s*0\s*}|{\s*' + members + '(0|NULL)\s*,' '\s*' + members + '(0|NULL)\s*}') errors_found = 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27254 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id2f5ba897ec83f34f8d3c4425353c0baf309bb6d Gerrit-Change-Number: 27254 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged