Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35007?usp=email )

Change subject: Use polling based LAPDm with frame numbers ......................................................................

Patch Set 1:

(15 comments)

File src/common/l1sap.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12396): https://gerrit.osmocom.org/c/osmo-bts/+/35007/comment/4a9668cd_1886b912 PS1, Line 1973: * received, substract one frame number, so that timeout is processed next time after FACCH is received. 'substract' may be misspelled - perhaps 'subtract'?

File src/common/oml.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12396): https://gerrit.osmocom.org/c/osmo-bts/+/35007/comment/280953d3_1fd5eb50 PS1, Line 534: [T200_SDCCH] = 4+32, code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12396): https://gerrit.osmocom.org/c/osmo-bts/+/35007/comment/4aeb3c5e_b378a6bb PS1, Line 534: [T200_SDCCH] = 4+32, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12396): https://gerrit.osmocom.org/c/osmo-bts/+/35007/comment/9d29139a_a16df65d PS1, Line 535: [T200_FACCH_F] = 8+9, code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12396): https://gerrit.osmocom.org/c/osmo-bts/+/35007/comment/edaa9508_7166fd14 PS1, Line 535: [T200_FACCH_F] = 8+9, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12396): https://gerrit.osmocom.org/c/osmo-bts/+/35007/comment/153397a4_f5d72ca3 PS1, Line 536: [T200_FACCH_H] = 6+10, code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12396): https://gerrit.osmocom.org/c/osmo-bts/+/35007/comment/4d77a760_f5a10aad PS1, Line 536: [T200_FACCH_H] = 6+10, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12396): https://gerrit.osmocom.org/c/osmo-bts/+/35007/comment/9cedd651_0ea10e33 PS1, Line 537: [T200_SACCH_TCH_SAPI0] = 79+25+104, code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12396): https://gerrit.osmocom.org/c/osmo-bts/+/35007/comment/3c2f1692_35db9004 PS1, Line 537: [T200_SACCH_TCH_SAPI0] = 79+25+104, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12396): https://gerrit.osmocom.org/c/osmo-bts/+/35007/comment/43f920ca_0abdbc38 PS1, Line 538: [T200_SACCH_SDCCH] = 4+32+51, code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12396): https://gerrit.osmocom.org/c/osmo-bts/+/35007/comment/7230be4c_39bd5955 PS1, Line 538: [T200_SACCH_SDCCH] = 4+32+51, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12396): https://gerrit.osmocom.org/c/osmo-bts/+/35007/comment/63dc38d9_7a803461 PS1, Line 539: [T200_SDCCH_SAPI3] = 4+32+408, /* two seconds */ code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12396): https://gerrit.osmocom.org/c/osmo-bts/+/35007/comment/d87d7508_80ef854f PS1, Line 539: [T200_SDCCH_SAPI3] = 4+32+408, /* two seconds */ please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12396): https://gerrit.osmocom.org/c/osmo-bts/+/35007/comment/30114f54_bf33e0a9 PS1, Line 540: [T200_SACCH_TCH_SAPI3] = 79+25+104, code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12396): https://gerrit.osmocom.org/c/osmo-bts/+/35007/comment/e46b006f_ec82bf40 PS1, Line 540: [T200_SACCH_TCH_SAPI3] = 79+25+104, please, no spaces at the start of a line