Attention is currently required from: pespin, dexter. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32714 ) Change subject: TCH DL, FR & EFR: reshape SIDs per 06.31/06.81 section 5.1.2 ...................................................................... Patch Set 3: (5 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/b5cc6710_3f11d6ed PS2, Line 8: The new patchset has a reworded commit message - please review. File include/osmo-bts/lchan.h: https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/dc80b0a5_b2a1be97 PS2, Line 281: } nonamr; Done https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/fd4eefc1_b94817c8 PS2, Line 282: uint8_t last_cmr; Done File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/178637d9_25ae4dc5 PS2, Line 1315: if (lchan->type == GSM_LCHAN_TCH_F) Done https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/7a1659ad_24dea7cc PS2, Line 1334: bool is_nonamr_sid = false; Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32714 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I924ab21952dcf8bb03ba7ccef790474bf66fc9e5 Gerrit-Change-Number: 32714 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 May 2023 19:38:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment