Attention is currently required from: pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/32596 )
Change subject: layer23: Introduce apn_fsm
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/host/layer23/src/common/apn_fsm.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/32596/comment/56a36e9c_2f81617a
PS2, Line 139: apn_fsm_state_chg(fi, APN_ST_INACTIVE);
The problem is that I can't simply implement
everything at the same time in one commit, that would be impossible to review. Pushing
this in small bits allows other people already testing and contributing too.
Sure, just asking questions to understand the patches better, and to make sure some things
are intentional where it's not obvious to me. Thanks for the explanation!
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/32596
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I2cc732dfb020d31ab89025e7e22276b819dcb24a
Gerrit-Change-Number: 32596
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 May 2023 10:57:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment