Attention is currently required from: laforge. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/29950 )

Change subject: support for e1-tracer hardware ......................................................................

Patch Set 1: Code-Review+1

(2 comments)

Patchset:

PS1: Minor recommended change, but I'm not opposed to merging as-is.

File src/usb.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/29950/comment/c0b18293_ed3b9adb PS1, Line 993: if (!is_tracer) { I would just test on if (line_data->ep_out) and if (line_data->ep_fb) rather than is_tracer.

A bit of a nit pick but it's more consistent with the ep_int test and also in the future if e1d is tracing, it's one less things to change.