Attention is currently required from: osmith, arehbein.

Hello osmith, Jenkins Builder, arehbein, fixeria,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bts/+/31924

to look at the new patch set (#2).

Change subject: Rewrite pcu_sock_write() ......................................................................

Rewrite pcu_sock_write()

The code in that function is pretty rotten: * osmo_fd_write_disable() is called for each message in the queue, there's no need for that. Let's simply call it at the end if the queue is empty. * Asserting for obvious stuff like dequeue returning the first entry in the list. * Having error code path for empty message: That shouldn't happen, abort immediately.

With all thse changes, the function is way simpler, easy to read and more efficient.

Change-Id: I7ffff98cd8cdf2041bff486c3fde6f16365028d5 --- M src/common/pcu_sock.c 1 file changed, 32 insertions(+), 25 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/24/31924/2