Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30812 )
Change subject: layer23/sysinfo: implement decoding of SI13 Rest Octets ......................................................................
Patch Set 4:
(1 comment)
File src/host/layer23/include/osmocom/bb/common/sysinfo.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/30812/comment/0f0842d0_d0b878bb PS2, Line 74: uint8_t supported;
Yes, but <stdbool.h> in not used this file. […]
I do use bool wherever possible too. But here we're touching old code from 2010 and it's rather typical to see integers used to store boolean values. Not sure what exactly confuses you so much: 0 is false, anything else is true. As I said I prefer to stay consistent with the existing fields in this file. Feel free to submit patch(es) refactoring everything to use bool, if you have time.
-
fixeria