pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29797 ) Change subject: vty: Make use of new mgcp_client_pool_config_write() API ...................................................................... vty: Make use of new mgcp_client_pool_config_write() API Let's use the new API available in libosmo-mgcp-client to control more consciously where the mgw pool config is printed. Before this patch, the place where the node was printed was defined based on implementation details on how the enum of nodes are defined and installed. Change-Id: Ib2f04d96ca846d2d61af0b0c0ea1924609004952 Related: SYS#5987 Depends: osmo-mgw.git Change-Id I7a620cf47886d8ecab30ce369cf123d98ab842c5 --- M TODO-RELEASE M src/osmo-bsc/bsc_vty.c 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index d56a416..6dc738a 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -9,4 +9,4 @@ #library what description / commit summary line libosmogsm >1.7.0 BTS_FEAT_OSMUX, RSL_IE_OSMO_OSMUX_CID libosmocore >1.7.0 vty hexadecimal range support (location_area_code) -libosmomgcp-client >1.10.0 mgcp_client_pool_member_...() +libosmomgcp-client >1.10.0 mgcp_client_pool_member_...(), mgcp_client_pool_config_write() \ No newline at end of file diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index d32baf8..11fcfad 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -406,6 +406,7 @@ } neighbor_ident_vty_write_network(vty, " "); + mgcp_client_pool_config_write(vty, " "); return CMD_SUCCESS; } @@ -3455,7 +3456,7 @@ install_element(GSMNET_NODE, &cfg_net_nri_null_del_cmd); bts_vty_init(); - mgcp_client_pool_vty_init(GSMNET_NODE, MGW_NODE, " ", vty_global_gsm_network->mgw.mgw_pool); + mgcp_client_pool_vty_init(GSMNET_NODE, MGW_NODE, NULL, vty_global_gsm_network->mgw.mgw_pool); install_element(ENABLE_NODE, &drop_bts_cmd); install_element(ENABLE_NODE, &restart_bts_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29797 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib2f04d96ca846d2d61af0b0c0ea1924609004952 Gerrit-Change-Number: 29797 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged