Attention is currently required from: pespin.

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30125 )

Change subject: rtp_stream: allow multiple codecs / use codec filter from Assignment ......................................................................

Patch Set 4:

(1 comment)

Patchset:

PS4:

I have the feeling this commit is still renaming and changing logic both things at the same time, wh […]

i had this sort of separate once, but here we are now.

my opinion now is that it is better to rename "codec" to "codecs" at the same time when it changes to multiple codecs involved where there was only one before: this shows in one patch all the places that are affected by the change, e.g. 'git blame' will hint at this patch.

Especially when adding the function ".._add_one_codec()" it is better to have the other function named "..._add_codecs()", not ".._add_codec()".