Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39666?usp=email ) Change subject: s1gw_metrics: add histograms for gen_sctp:send delay ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: I am not sure either, but I don't think it would hurt a lot. Well, we know that `gen_sctp:send` is blocking. And with the current architecture, it's possible that it blocks the whole process, be it `sctp_server` or `sctp_client` module. If this happens, we would at least **see** that it's because of `gen_sctp:send` taking too long. Harald proposed a different architecture, in which a separate process is spawned for each S1AP PDU. This approach is more robust, because `gen_sctp:send` would only be blocking sending of a single PDU, letting the S1GW to process other PDUs in the meantime. Once this is implemented, we can even get rid of this histogram. I will upload an updated version soon. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7633a6e6182bda3fca4e7562e2b780b2b9f9708f Gerrit-Change-Number: 39666 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Mar 2025 18:52:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>