Attention is currently required from: fixeria.
arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/1627 )
Change subject: tests/conv: separate test logic
......................................................................
Patch Set 4:
(1 comment)
File tests/conv/conv.c:
https://gerrit.osmocom.org/c/libosmocore/+/1627/comment/99699c9d_53b31686
PS4, Line 42: return -1;
Yeah, it's tests. I would not be spending time
fixing this.
Would it be possible to separate test code in Coverity from
'regular' code? I'd say that would make the Coverity issue list more useful
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/1627
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idbdc7e19cb9b9a36cd1fccd621cd858e87530d98
Gerrit-Change-Number: 1627
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-CC: arehbein <arehbein(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 26 Mar 2023 22:07:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment